Refonte du redimensionement des images sur les groupes de salles #128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucien-chastan
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Le redimensionnements des images à un coût non négligeable côté serveur, surtout à l'ajout de voie indoor où un certain nombre de variante sont faite en peu de temps
Le module qui permet de checker l'existence d'une variante, de la créer et de l'envoyé sur R2 représente en moyen 17% du temps serveur. C'est le premier poste de dépense, de 10% supérieur au second poste.
On test de passer par Image Transform via URL de cloudflare sur les pages 'groupe de salle' pour tester le développement sur des pages peu demandées et peu impactantes
Pour ça on ajoute un mixine qui permet de choisir à la volet la variante d'une image, ça permettrai aussi de mieux gérer les variantes par rapport au cas d'usage
PR back : oblyk/oblyk-api#18