Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark @filter directive as repeatable in the schema #438

Closed
obi1kenobi opened this issue Aug 7, 2023 · 1 comment
Closed

Mark @filter directive as repeatable in the schema #438

obi1kenobi opened this issue Aug 7, 2023 · 1 comment
Labels
A-schema Area: the data model that queries use C-enhancement Category: raise the bar on expectations E-hard Call for participation: experience needed to fix: hard / a lot. E-help-wanted Call for participation: help is requested to fix this issue. E-mentor Call for participation: mentorship is available for this issue. R-relnotes Release: document this in the release notes of the next release

Comments

@obi1kenobi
Copy link
Owner

obi1kenobi commented Aug 7, 2023

Trustfall queries are allowed to have more than one filter on the same field. Such repeatable directives were defined to need a repeatable keyword in the SDL, per a recent GraphQL spec, and our @filter directive should have it.

This would improve compatibility and user experience when using GraphQL editors and LSP integrations, since it will eliminate a source of incorrect "invalid query" errors.

Unfortunately, our current parser does not support repeatable directives so that would be a parse error.

When updating to a newer parser, make the @filter directive repeatable.

@obi1kenobi obi1kenobi added A-schema Area: the data model that queries use C-enhancement Category: raise the bar on expectations E-help-wanted Call for participation: help is requested to fix this issue. E-mentor Call for participation: mentorship is available for this issue. E-hard Call for participation: experience needed to fix: hard / a lot. R-relnotes Release: document this in the release notes of the next release labels Aug 7, 2023
@obi1kenobi
Copy link
Owner Author

Resolved by #458.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-schema Area: the data model that queries use C-enhancement Category: raise the bar on expectations E-hard Call for participation: experience needed to fix: hard / a lot. E-help-wanted Call for participation: help is requested to fix this issue. E-mentor Call for participation: mentorship is available for this issue. R-relnotes Release: document this in the release notes of the next release
Projects
None yet
Development

No branches or pull requests

1 participant