Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

go/runtime/host/tdx: Add support for persistent image overlay #6005

Merged
merged 2 commits into from
Jan 17, 2025
Merged

go/runtime/host/tdx: Add support for persistent image overlay #6005

merged 2 commits into from
Jan 17, 2025

Conversation

kostko
Copy link
Member

@kostko kostko commented Jan 17, 2025

Closes #5999

@netlify Netlify
Copy link

netlify bot commented Jan 17, 2025 •
edited
Loading

✅ Deploy Preview for oasisprotocol-oasis-core canceled.

Name Link
🔨 Latest commit 95c0127
🔍 Latest deploy log https://app.netlify.com/sites/oasisprotocol-oasis-core/deploys/678a4abdc7602b00080369de

@kostko kostko force-pushed the kostko/feature/tdx-persistent-image branch from 31ceff5 to fcc8dca Compare January 17, 2025 09:23
@kostko kostko marked this pull request as ready for review January 17, 2025 09:24
@kostko kostko force-pushed the kostko/feature/tdx-persistent-image branch 4 times, most recently from dcf8a69 to a5589fe Compare January 17, 2025 10:04
peternose
peternose reviewed Jan 17, 2025
View reviewed changes
@kostko kostko force-pushed the kostko/feature/tdx-persistent-image branch 4 times, most recently from 63d03c3 to 54e2322 Compare January 17, 2025 11:39
peternose
peternose approved these changes Jan 17, 2025
View reviewed changes
Copy link
Contributor

@peternose peternose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@kostko kostko force-pushed the kostko/feature/tdx-persistent-image branch from 54e2322 to f35a648 Compare January 17, 2025 12:17
@kostko kostko force-pushed the kostko/feature/tdx-persistent-image branch from f35a648 to 95c0127 Compare January 17, 2025 12:19
@kostko kostko enabled auto-merge January 17, 2025 12:57
@kostko kostko merged commit 15b996e into master Jan 17, 2025
5 checks passed
@kostko kostko deleted the kostko/feature/tdx-persistent-image branch January 17, 2025 13:09
@codecov Codecov
Copy link

codecov bot commented Jan 17, 2025

Codecov Report

Attention: Patch coverage is 14.54545% with 47 lines in your changes missing coverage. Please review.

Project coverage is 64.64%. Comparing base (f779792) to head (95c0127).
Report is 6 commits behind head on master.

Files with missing lines Patch % Lines
go/runtime/host/tdx/qemu.go 0.00% 47 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #6005      +/-   ##
==========================================
- Coverage   65.33%   64.64%   -0.70%     
==========================================
  Files         633      633              
  Lines       64889    64941      +52     
==========================================
- Hits        42395    41979     -416     
- Misses      17544    17998     +454     
- Partials     4950     4964      +14

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peternose peternose peternose approved these changes

@peterjgilbert peterjgilbert Awaiting requested review from peterjgilbert peterjgilbert is a code owner

@pro-wh pro-wh Awaiting requested review from pro-wh pro-wh is a code owner

@ptrus ptrus Awaiting requested review from ptrus ptrus is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support persistent storage for TDX
2 participants
@kostko @peternose