Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runtime/src/enclave_rpc: Support peer feedback for concurrent requests #5872

Merged
merged 3 commits into from
Sep 30, 2024

Conversation

peternose
Copy link
Contributor

@peternose peternose commented Sep 30, 2024

Example logs:

// First client.
{"caller":"keymanager.go:242","level":"debug","module":"worker/keymanager","msg":"received peer feedback from runtime","peer_feedback":"failure","request_id":11876174929579737116,"ts":"2024-09-30T11:13:55.971535462Z","valid":true}
{"caller":"keymanager.go:242","level":"debug","module":"worker/keymanager","msg":"received peer feedback from runtime","peer_feedback":"success","request_id":11876174929579737117,"ts":"2024-09-30T11:13:55.972354408Z","valid":true}
// No peers found error, so peer feedback is never stored.
{"caller":"keymanager.go:242","level":"debug","module":"worker/keymanager","msg":"received peer feedback from runtime","peer_feedback":"failure","request_id":11876174929579737118,"ts":"2024-09-30T11:13:55.972777804Z","valid":false}
// Second client.
{"caller":"keymanager.go:242","level":"debug","module":"worker/keymanager","msg":"received peer feedback from runtime","peer_feedback":"success","request_id":11876174933874704385,"ts":"2024-09-30T11:14:10.333719181Z","valid":true}

Copy link

netlify bot commented Sep 30, 2024

Deploy Preview for oasisprotocol-oasis-core canceled.

Name Link
🔨 Latest commit c874465
🔍 Latest deploy log https://app.netlify.com/sites/oasisprotocol-oasis-core/deploys/66fa952d650a54000873d7f0

@peternose peternose linked an issue Sep 30, 2024 that may be closed by this pull request
@peternose peternose force-pushed the peternose/feature/concurrent-peer-feedbacks branch 3 times, most recently from 10a9112 to 623424a Compare September 30, 2024 07:18
@peternose peternose marked this pull request as ready for review September 30, 2024 07:18
@peternose peternose force-pushed the peternose/feature/concurrent-peer-feedbacks branch 4 times, most recently from 309f6b3 to d1e1ffb Compare September 30, 2024 08:54
@peternose peternose force-pushed the peternose/feature/concurrent-peer-feedbacks branch 2 times, most recently from d0a6600 to 2e38e9d Compare September 30, 2024 11:27
@peternose peternose force-pushed the peternose/feature/concurrent-peer-feedbacks branch from 2e38e9d to 0927e0c Compare September 30, 2024 11:43
@peternose peternose force-pushed the peternose/feature/concurrent-peer-feedbacks branch from 0927e0c to a06793e Compare September 30, 2024 11:51
@peternose peternose force-pushed the peternose/feature/concurrent-peer-feedbacks branch from a06793e to c874465 Compare September 30, 2024 12:10
@peternose peternose enabled auto-merge September 30, 2024 12:11
@peternose peternose merged commit 280d2ef into master Sep 30, 2024
5 checks passed
@peternose peternose deleted the peternose/feature/concurrent-peer-feedbacks branch September 30, 2024 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support peer feedback for concurrent requests
2 participants