-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
keymanager: Add mock trusted signers for debug mock SGX builds #5852
Conversation
✅ Deploy Preview for oasisprotocol-oasis-core canceled.
|
aaab524
to
663713f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we remove trusted_signers()
?
In the |
663713f
to
28736a2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good then.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5852 +/- ##
==========================================
- Coverage 64.96% 64.93% -0.03%
==========================================
Files 622 622
Lines 63492 63492
==========================================
- Hits 41246 41229 -17
+ Misses 17399 17379 -20
- Partials 4847 4884 +37 ☔ View full report in Codecov by Sentry. |
Useful after #5851 to allow configuring the set of mock trusted signers used by net runner.