go/consensus: add GasUsed to transaction results and Size to block header #5761
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for oasisprotocol-oasis-core canceled.
|
ptrus
force-pushed
the
ptrus/feature/tx-gas-used
branch
from
1c17caf to
2b1d7a0
Compare
ptrus
changed the title
ptrus
force-pushed
the
ptrus/feature/tx-gas-used
branch
3 times, most recently
from
ff637b0 to
4492b2a
Compare
ptrus
requested review from
kostko,
peterjgilbert,
pro-wh and
peternose
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5761 +/- ##
==========================================
- Coverage 64.95% 64.87% -0.09%
==========================================
Files 620 620
Lines 63330 63339 +9
==========================================
- Hits 41138 41093 -45
- Misses 17346 17377 +31
- Partials 4846 4869 +23 ☔ View full report in Codecov by Sentry. |
peternose
reviewed
Jul 8, 2024
go/consensus/tests/tester.go
Outdated
| @@ -44,6 +44,7 @@ func ConsensusImplementationTests(t *testing.T, backend consensus.ClientBackend) | |||
| require.NoError(err, "GetBlock") | |||
| require.NotNil(blk, "returned block should not be nil") | |||
| require.True(blk.Height > 0, "block height should be greater than zero") | |||
| require.True(blk.Size > 0, "block size should be greater than zero") | |||
There was a problem hiding this comment.
Suggested change
| require.True(blk.Size > 0, "block size should be greater than zero") | |
| require.EqualValues(blk.Size, uint64(1178), "block size should match") |
There was a problem hiding this comment.
I don't think this will be deterministic as it depends on what transactions are in the "latest" block?
peternose
reviewed
Jul 8, 2024
go/consensus/tests/tester.go
Outdated
| @@ -44,6 +44,7 @@ func ConsensusImplementationTests(t *testing.T, backend consensus.ClientBackend) | |||
| require.NoError(err, "GetBlock") | |||
| require.NotNil(blk, "returned block should not be nil") | |||
| require.True(blk.Height > 0, "block height should be greater than zero") | |||
| require.True(blk.Size > 0, "block size should be greater than zero") | |||
There was a problem hiding this comment.
Suggested change
| require.True(blk.Size > 0, "block size should be greater than zero") | |
| require.EqualValues(blk.Size, uint64(1178), "block size should match") |
peternose
approved these changes
Jul 9, 2024
ptrus
force-pushed
the
ptrus/feature/tx-gas-used
branch
2 times, most recently
from
8ce5f78 to
b394fea
Compare
peternose
approved these changes
Jul 11, 2024
ptrus
force-pushed
the
ptrus/feature/tx-gas-used
branch
from
b394fea to
90fa3ab
Compare
peternose
approved these changes
Jul 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.