Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go/worker/keymanager: Fix race condition when accessing status fields #5529

Merged
merged 5 commits into from
Jan 16, 2024

Conversation

peternose
Copy link
Contributor

No description provided.

@peternose peternose added the c:bug Category: bug label Jan 16, 2024
@peternose peternose marked this pull request as ready for review January 16, 2024 13:53
Copy link

codecov bot commented Jan 16, 2024

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (d08e646) 66.32% compared to head (135bd82) 67.02%.
Report is 1 commits behind head on master.

Files Patch % Lines
go/worker/keymanager/worker.go 83.33% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5529      +/-   ##
==========================================
+ Coverage   66.32%   67.02%   +0.70%     
==========================================
  Files         534      534              
  Lines       56584    56580       -4     
==========================================
+ Hits        37530    37924     +394     
+ Misses      14635    14249     -386     
+ Partials     4419     4407      -12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@peternose peternose merged commit a19f3d3 into master Jan 16, 2024
3 checks passed
@peternose peternose deleted the peternose/bugfix/km-race-conditions branch January 16, 2024 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c:bug Category: bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants