Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runtime: Add roothash round roots rust state wrappers #5457

Merged
merged 2 commits into from
Nov 20, 2023

Conversation

ptrus
Copy link
Member

@ptrus ptrus commented Nov 20, 2023

TODO:

  • add roothash interoperability tests (as it is done for most other state wrappers)

@ptrus ptrus force-pushed the ptrus/feature/rs-round-roots branch from bd9e065 to fbb9eda Compare November 20, 2023 12:20
@ptrus ptrus force-pushed the ptrus/feature/rs-round-roots branch 2 times, most recently from b20a9ad to b7b159e Compare November 20, 2023 15:31
@ptrus ptrus force-pushed the ptrus/feature/rs-round-roots branch from b7b159e to 0039ebf Compare November 20, 2023 16:11
Copy link

codecov bot commented Nov 20, 2023

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (725c84a) 66.51% compared to head (0039ebf) 66.84%.
Report is 1 commits behind head on master.

Files Patch % Lines
go/consensus/cometbft/apps/roothash/state/state.go 44.44% 0 Missing and 5 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5457      +/-   ##
==========================================
+ Coverage   66.51%   66.84%   +0.33%     
==========================================
  Files         533      533              
  Lines       56390    56390              
==========================================
+ Hits        37505    37694     +189     
+ Misses      14484    14289     -195     
- Partials     4401     4407       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kostko
Copy link
Member

kostko commented Nov 20, 2023

Also please backport this, so we can have it available in the SDK early. Maybe as part of (or after) #5454.

@ptrus ptrus merged commit 0fe5e68 into master Nov 20, 2023
@ptrus ptrus deleted the ptrus/feature/rs-round-roots branch November 20, 2023 19:44
@ptrus ptrus mentioned this pull request Nov 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants