runtime: Create controller in RpcClient constructor #5450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kostko
force-pushed
the
kostko/fix/erpc-client-controller
branch
from
fc45bed to
e4bc41c
Compare
Previously if no RPC calls were initiated by the runtime, the client controller task was never spawned which caused quote policy update requests to pile up in the command queue, eventually blocking the entire runtime from processing requests. Since the async runtime is now available early on during initialization, we can spawn the controller in the RpcClient constructor, avoiding these problems.
kostko
force-pushed
the
kostko/fix/erpc-client-controller
branch
from
e4bc41c to
4a1efe9
Compare
kostko
requested review from
peterjgilbert,
pro-wh,
ptrus and
peternose
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5450 +/- ##
==========================================
+ Coverage 66.51% 66.79% +0.27%
==========================================
Files 533 533
Lines 56387 56387
==========================================
+ Hits 37507 37662 +155
+ Misses 14478 14320 -158
- Partials 4402 4405 +3 ☔ View full report in Codecov by Sentry. |
ptrus
approved these changes
Nov 16, 2023
peternose
reviewed
Nov 16, 2023
| cmdq: rx, | ||
| cmdq_tx: tx.clone(), | ||
| }; | ||
| tokio::spawn(controller.run()); |
There was a problem hiding this comment.
Looks good, although I'm not a big fan of creating tasks or goroutines in the constructor, as they are hidden from the caller, not under caller's control and they usually cause troubles in tests (in this case, one must ensure Tokio runtime is available).
There was a problem hiding this comment.
True, but this way it avoids a needless atomic + mutex.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously if no RPC calls were initiated by the runtime, the client controller task was never spawned which caused quote policy update requests to pile up in the command queue, eventually blocking the entire runtime from processing requests.
Since the async runtime is now available early on during initialization, we can spawn the controller in the RpcClient constructor, avoiding these problems.