go/runtime/host/sandbox: Release lock before calling into runtime #5438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kostko
force-pushed
the
kostko/fix/rt-sandbox-deadlock
branch
from
d5416b7 to
492b663
Compare
peternose
approved these changes
Nov 13, 2023
kostko
force-pushed
the
kostko/fix/rt-sandbox-deadlock
branch
from
071e5fe to
fefe4e6
Compare
|
We could also fix |
Similar to how this is handled in the multi runtime host, we need to release the lock before calling into the runtime as otherwise this could lead to a deadlock in certain situations.
kostko
force-pushed
the
kostko/fix/rt-sandbox-deadlock
branch
from
fefe4e6 to
ca85e65
Compare
peternose
reviewed
Nov 13, 2023
peternose
approved these changes
Nov 13, 2023
kostko
force-pushed
the
kostko/fix/rt-sandbox-deadlock
branch
from
ca85e65 to
e022fa9
Compare
peternose
approved these changes
Nov 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to how this is handled in the multi runtime host, we need to release the lock before calling into the runtime as otherwise this could lead to a deadlock in certain situations.