Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go/worker/storage: Disable storage worker when no runtimes configured #5394

Merged
merged 4 commits into from
Oct 11, 2023

Conversation

kostko
Copy link
Member

@kostko kostko commented Oct 11, 2023

No description provided.

@kostko kostko force-pushed the kostko/fix/storage-worker-nort branch from ec49835 to 54f9713 Compare October 11, 2023 11:18
@kostko kostko marked this pull request as ready for review October 11, 2023 11:23
@kostko kostko force-pushed the kostko/fix/storage-worker-nort branch from 54f9713 to 3edf6f3 Compare October 11, 2023 11:39
@codecov
Copy link

codecov bot commented Oct 11, 2023

Codecov Report

Merging #5394 (9ed07e5) into master (a815aa2) will decrease coverage by 0.27%.
Report is 17 commits behind head on master.
The diff coverage is 72.17%.

❗ Current head 9ed07e5 differs from pull request most recent head 61eedc8. Consider uploading reports for the commit 61eedc8 to get more accurate results

@@            Coverage Diff             @@
##           master    #5394      +/-   ##
==========================================
- Coverage   66.59%   66.33%   -0.27%     
==========================================
  Files         534      534              
  Lines       56276    56307      +31     
==========================================
- Hits        37476    37349     -127     
- Misses      14366    14548     +182     
+ Partials     4434     4410      -24     
Files Coverage Δ
go/config/config.go 58.66% <100.00%> (ø)
go/ias/config/config.go 100.00% <100.00%> (ø)
go/ias/init.go 100.00% <100.00%> (ø)
go/oasis-node/cmd/config/migrate/migrate.go 69.97% <100.00%> (+3.60%) ⬆️
go/oasis-node/cmd/control/control.go 21.56% <ø> (ø)
go/oasis-node/cmd/node/node.go 50.63% <ø> (-0.16%) ⬇️
go/oasis-node/cmd/node/unsafe_reset.go 57.35% <ø> (ø)
go/runtime/host/sgx/sgx.go 68.75% <ø> (ø)
go/runtime/registry/config.go 67.08% <100.00%> (ø)
go/runtime/registry/registry.go 75.27% <100.00%> (ø)
... and 5 more

... and 74 files with indirect coverage changes

@kostko kostko merged commit 5c1b894 into master Oct 11, 2023
@kostko kostko deleted the kostko/fix/storage-worker-nort branch October 11, 2023 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants