runtime: Bump tendermint-rs to 0.29.0 #5190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kostko
force-pushed
the
kostko/feature/bump-tendermint-0.29.0
branch
2 times, most recently
from
d63a09d to
e43c0a2
Compare
kostko
requested review from
peterjgilbert,
pro-wh,
ptrus and
peternose
as code owners
kostko
force-pushed
the
kostko/feature/bump-tendermint-0.29.0
branch
from
e43c0a2 to
0a48067
Compare
peternose
approved these changes
Feb 21, 2023
| VerificationError::invalid_signature( | ||
| signed_vote.signature().as_bytes().to_vec(), | ||
| Box::new(validator), | ||
| sign_bytes.as_ref().into(), |
There was a problem hiding this comment.
We changed the error as now we are using sign_bytes and not Hash::digest_bytes_list(&[TENDERMINT_CONTEXT, &sign_bytes]) anymore. But I think that is not a problem, just saying.
There was a problem hiding this comment.
Ah that's true, but this is a minor thing to pay for not having to maintain a copy of the voting power calculator.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.