Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crypto/x25519: Add type-safe X25519 private/public key types #5121

Merged
merged 2 commits into from
Jan 10, 2023

Conversation

peternose
Copy link
Contributor

@peternose peternose commented Jan 10, 2023

Waiting for oasisprotocol/curve25519-voi#120 to be merged.

@peternose peternose force-pushed the peternose/internal/x25519-key-types branch 2 times, most recently from da73ea9 to f535e9a Compare January 10, 2023 09:56
@peternose peternose marked this pull request as ready for review January 10, 2023 09:56
@peternose peternose force-pushed the peternose/internal/x25519-key-types branch from f535e9a to 19a7334 Compare January 10, 2023 11:23
@codecov
Copy link

codecov bot commented Jan 10, 2023

Codecov Report

Merging #5121 (19a7334) into master (541dc2f) will decrease coverage by 0.04%.
The diff coverage is 54.09%.

❗ Current head 19a7334 differs from pull request most recent head 0f49a44. Consider uploading reports for the commit 0f49a44 to get more accurate results

@@            Coverage Diff             @@
##           master    #5121      +/-   ##
==========================================
- Coverage   66.84%   66.80%   -0.05%     
==========================================
  Files         497      496       -1     
  Lines       53273    53263      -10     
==========================================
- Hits        35611    35583      -28     
- Misses      13321    13334      +13     
- Partials     4341     4346       +5     
Impacted Files Coverage Δ
go/keymanager/api/api.go 80.64% <ø> (ø)
go/runtime/host/protocol/types.go 54.54% <ø> (ø)
...consensus/tendermint/apps/keymanager/keymanager.go 62.05% <18.18%> (-1.59%) ⬇️
go/oasis-node/cmd/keymanager/keymanager.go 47.38% <36.36%> (-0.33%) ⬇️
go/runtime/registry/host.go 70.11% <88.00%> (-2.25%) ⬇️
go/common/crypto/mrae/deoxysii/asymmetric.go 77.77% <100.00%> (ø)
go/consensus/tendermint/apps/staking/auth.go 62.96% <0.00%> (-7.41%) ⬇️
go/runtime/host/sandbox/sandbox.go 70.00% <0.00%> (-6.56%) ⬇️
go/common/cbor/codec.go 78.37% <0.00%> (-5.41%) ⬇️
go/runtime/host/protocol/connection.go 68.79% <0.00%> (-5.27%) ⬇️
... and 27 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@peternose peternose force-pushed the peternose/internal/x25519-key-types branch from 19a7334 to 0f49a44 Compare January 10, 2023 12:24
@peternose peternose merged commit 7c790b9 into master Jan 10, 2023
@peternose peternose deleted the peternose/internal/x25519-key-types branch January 10, 2023 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants