keymanager/src/client: Fetch public keys using insecure RPC requests #5101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peternose
force-pushed
the
peternose/feature/verify-public-keys
branch
from
22baa99 to
89139ec
Compare
peternose
force-pushed
the
peternose/feature/verify-public-keys
branch
from
89139ec to
068ec2f
Compare
Codecov Report
@@ Coverage Diff @@
## master #5101 +/- ##
==========================================
- Coverage 66.84% 66.78% -0.07%
==========================================
Files 497 497
Lines 53273 53197 -76
==========================================
- Hits 35611 35525 -86
- Misses 13321 13341 +20
+ Partials 4341 4331 -10
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
peternose
force-pushed
the
peternose/feature/verify-public-keys
branch
3 times, most recently
from
4093b34 to
08ecd05
Compare
peternose
requested review from
kostko,
Yawning,
peterjgilbert,
pro-wh and
ptrus
as code owners
kostko
reviewed
Jan 3, 2023
keymanager/src/crypto/types.rs
Outdated
| /// Signed public key. | ||
| #[derive(Clone, Debug, Default, PartialEq, Eq, cbor::Encode, cbor::Decode)] | ||
| pub struct SignedPublicKey { | ||
| /// Public key. | ||
| pub key: PublicKey, | ||
| /// Checksum of the key manager state. | ||
| pub checksum: Vec<u8>, | ||
| /// Sign(sk, (key || checksum)) from the key manager. | ||
| /// Sign(sk, (key || checksum || runtime id || key pair id || epoch || expiration date) from |
There was a problem hiding this comment.
Suggested change
| /// Sign(sk, (key || checksum || runtime id || key pair id || epoch || expiration date) from | |
| /// Sign(sk, (key || checksum || runtime id || key pair id || epoch || expiration epoch)) from |
peternose
force-pushed
the
peternose/feature/verify-public-keys
branch
from
08ecd05 to
b4b98d1
Compare
kostko
approved these changes
Jan 8, 2023
peternose
force-pushed
the
peternose/feature/verify-public-keys
branch
from
b4b98d1 to
2bf42ba
Compare
peternose
force-pushed
the
peternose/feature/verify-public-keys
branch
from
2bf42ba to
b82ebd3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task
Fetch and verify public long-term/ephemeral runtime keys through an insecure channel.
Test
Key manager upgrade tested locally with e2e test. Upgrade works as we allow empty runtime signing keys. An alternative would be to be strict here, but then one key manager would not be included in the node list because of the
Runtime signing key mismatch for runtimeerror. Not sure if this is a problem though, as the new manager will be added to the list as soon as the old one is deregistered.