Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runtime/consensus/tendermint/verifier: Refactor verifier #4934

Merged
merged 3 commits into from
Sep 19, 2022

Conversation

peternose
Copy link
Contributor

Refactor verifier to group verify/update time/update block operations
Also consider splitting the tendermint/verifier into multiple modules as it is getting quite large.

@peternose peternose force-pushed the peternose/internal/refactor-verifier branch 3 times, most recently from af32127 to 25ce804 Compare September 14, 2022 08:02
@codecov
Copy link

codecov bot commented Sep 14, 2022

Codecov Report

Merging #4934 (c7a7ea5) into master (06012a8) will increase coverage by 0.13%.
The diff coverage is 70.39%.

@@            Coverage Diff             @@
##           master    #4934      +/-   ##
==========================================
+ Coverage   66.64%   66.78%   +0.13%     
==========================================
  Files         464      464              
  Lines       51204    51221      +17     
==========================================
+ Hits        34127    34207      +80     
+ Misses      12891    12828      -63     
  Partials     4186     4186              
Impacted Files Coverage Δ
go/common/version/version.go 80.26% <ø> (ø)
go/consensus/tendermint/apps/roothash/api.go 100.00% <ø> (ø)
go/keymanager/api/api.go 80.64% <0.00%> (ø)
go/registry/api/api.go 57.46% <0.00%> (ø)
go/runtime/host/protocol/types.go 54.54% <ø> (ø)
go/runtime/host/sgx/ecdsa.go 7.29% <0.00%> (-0.41%) ⬇️
go/worker/common/committee/runtime_host.go 83.33% <ø> (+27.77%) ⬆️
go/worker/keymanager/worker.go 64.85% <ø> (-1.10%) ⬇️
go/common/node/sgx.go 75.22% <51.28%> (-12.62%) ⬇️
go/runtime/registry/host.go 69.93% <63.63%> (+0.41%) ⬆️
... and 58 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@peternose peternose marked this pull request as ready for review September 14, 2022 08:57
@peternose peternose added c:consensus/cometbft Category: CometBFT rust labels Sep 14, 2022
Copy link
Member

@kostko kostko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems strange that the store (LRU light block store) was left out of the verifier module as it is only used by the verifier. It should probably be moved there. But there is now also a different kind of store (the trust root store) in the verifier::store module.

@peternose peternose removed the c:consensus/cometbft Category: CometBFT label Sep 14, 2022
@peternose peternose force-pushed the peternose/internal/refactor-verifier branch from 25ce804 to 95021a6 Compare September 14, 2022 14:07
@peternose peternose requested a review from kostko September 15, 2022 15:12
@peternose peternose force-pushed the peternose/internal/refactor-verifier branch from 95021a6 to c7a7ea5 Compare September 18, 2022 21:49
@peternose peternose merged commit 77edc26 into master Sep 19, 2022
@peternose peternose deleted the peternose/internal/refactor-verifier branch September 19, 2022 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants