-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
go: Add key manager worker status to node status #4883
Conversation
2aa1fa4
to
1fd5d63
Compare
Codecov Report
@@ Coverage Diff @@
## master #4883 +/- ##
==========================================
+ Coverage 66.54% 66.55% +0.01%
==========================================
Files 452 454 +2
Lines 50418 50524 +106
==========================================
+ Hits 33551 33627 +76
- Misses 12705 12726 +21
- Partials 4162 4171 +9
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
1fd5d63
to
643cf77
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One minor thing, otherwise looks good.
Also do squash the two commits as the second one actually fixes an issue introduced by the first one :) |
fdaa307
to
8fc6860
Compare
Task
Currently the key manager worker does not report any status as part of the GetStatus node control gRPC API call. It should provide some useful information about the operation of the key manager node.
Test
Tested locally using default fixture, simple-keymanager and minimal-runtime: