go/consensus/tendermint/apps/beacon: Breaking VRF fixes #4668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yawning
added
c:bug
Yawning
changed the title
|
Let's rebase now that master can break consensus. |
Yawning
force-pushed
the
yawning/fix/breaking-vrf-changes
branch
2 times, most recently
from
a4144cb to
c6ae937
Compare
Yawning
requested review from
kostko,
peterjgilbert,
pro-wh and
ptrus
as code owners
kostko
approved these changes
Oct 25, 2022
The PVSS backend is no longer present in 22.x and so the field is now removed, and even genesis registrations without a VRF signing key will be rejected.
Yawning
force-pushed
the
yawning/fix/breaking-vrf-changes
branch
from
c6ae937 to
7a2e2e2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This collects all the VRF related changes that are consensus breaking in one branch so I only have one thing to rebase when I can merge all of these. Note that none of these fixes are security critical.
Fixes #4394
Fixes #4393
Fixes #4667
Fixes #4838