Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

oasis-net-runner: Support fixtures without a keymanager #4533

Closed
ptrus opened this issue Mar 3, 2022 · 0 comments · Fixed by #4564
Closed

oasis-net-runner: Support fixtures without a keymanager #4533

ptrus opened this issue Mar 3, 2022 · 0 comments · Fixed by #4564
Assignees
Labels
c:bug Category: bug p:3 Priority: nice to have s:good first issue Status: good for newcomers

Comments

@ptrus
Copy link
Member

ptrus commented Mar 3, 2022

Creating a fixture without a keymanager fails in oasis-core 22.0, since setting the keymanager binary to an empty path fails with:

Error: root: failed to instantiate fixture: oasis/runtime: failed to read ELF binary: open : no such file or directory

The keymanager deployment binary should probably only be set if if usingKeymanager

Deployments: []oasis.DeploymentCfg{
{
Binaries: map[node.TEEHardware]string{
tee: viper.GetString(cfgKeymanagerBinary),
},
},
},

@ptrus ptrus added s:good first issue Status: good for newcomers p:3 Priority: nice to have c:bug Category: bug labels Mar 3, 2022
@ptrus ptrus self-assigned this Mar 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c:bug Category: bug p:3 Priority: nice to have s:good first issue Status: good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant