Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go/consensus/tendermint/roothash: Only index the correct runtime #4351

Merged
merged 1 commit into from
Nov 11, 2021

Conversation

kostko
Copy link
Member

@kostko kostko commented Nov 11, 2021

In case multiple runtimes were being tracked, the indexing process could
incorrectly set the last indexed round which could make it skip to index a
round.

@kostko kostko added c:bug Category: bug c:runtime/indexer Category: runtime block and/or tag indexer labels Nov 11, 2021
In case multiple runtimes were being tracked, the indexing process could
incorrectly set the last indexed round which could make it skip to index a
round.
@kostko kostko force-pushed the kostko/fix/roothash-blk-index-multirt branch from 7ff3188 to 04db11b Compare November 11, 2021 07:30
@codecov
Copy link

codecov bot commented Nov 11, 2021

Codecov Report

Merging #4351 (04db11b) into master (3f28a5c) will decrease coverage by 0.78%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4351      +/-   ##
==========================================
- Coverage   69.38%   68.59%   -0.79%     
==========================================
  Files         411      411              
  Lines       47417    47418       +1     
==========================================
- Hits        32898    32527     -371     
- Misses      10516    10851     +335     
- Partials     4003     4040      +37     
Impacted Files Coverage Δ
go/consensus/tendermint/roothash/roothash.go 69.64% <66.66%> (-3.29%) ⬇️
go/ias/http/http.go 20.33% <0.00%> (-44.07%) ⬇️
go/keymanager/api/policy_sgx.go 33.33% <0.00%> (-13.34%) ⬇️
go/storage/api/context.go 87.87% <0.00%> (-12.13%) ⬇️
go/runtime/host/sandbox/sandbox.go 67.03% <0.00%> (-12.09%) ⬇️
go/consensus/tendermint/abci/state/state.go 61.53% <0.00%> (-7.70%) ⬇️
go/consensus/tendermint/apps/staking/auth.go 70.37% <0.00%> (-7.41%) ⬇️
go/oasis-node/cmd/ias/auth.go 68.96% <0.00%> (-6.90%) ⬇️
go/common/sgx/aesm/aesm.go 63.63% <0.00%> (-6.37%) ⬇️
go/storage/api/mux.go 56.34% <0.00%> (-6.35%) ⬇️
... and 47 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f28a5c...04db11b. Read the comment docs.

@kostko kostko merged commit f7dcdc1 into master Nov 11, 2021
@kostko kostko deleted the kostko/fix/roothash-blk-index-multirt branch November 11, 2021 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c:bug Category: bug c:runtime/indexer Category: runtime block and/or tag indexer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants