Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go/runtime/host/sandbox: Add deadline to bwrap pipes #4111

Merged
merged 2 commits into from
Jul 7, 2021

Conversation

kostko
Copy link
Member

@kostko kostko commented Jul 3, 2021

Fixes #4102

@kostko kostko requested a review from tjanez July 3, 2021 11:59
@kostko kostko force-pushed the kostko/fix/bwrap-add-timeout branch from f82b1ba to 93574c7 Compare July 3, 2021 12:00
kostko added 2 commits July 6, 2021 17:57
This prevents the constructor from blocking forever in case something is
wrong with the sandbox setup.
@kostko kostko marked this pull request as ready for review July 6, 2021 15:58
@kostko kostko force-pushed the kostko/fix/bwrap-add-timeout branch from 93574c7 to 1c5963f Compare July 6, 2021 15:58
@codecov
Copy link

codecov bot commented Jul 6, 2021

Codecov Report

Merging #4111 (1c5963f) into master (ebd5673) will decrease coverage by 0.55%.
The diff coverage is 12.50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4111      +/-   ##
==========================================
- Coverage   66.87%   66.32%   -0.56%     
==========================================
  Files         410      410              
  Lines       42391    42398       +7     
==========================================
- Hits        28350    28119     -231     
- Misses      10036    10282     +246     
+ Partials     4005     3997       -8     
Impacted Files Coverage Δ
go/worker/compute/executor/committee/node.go 64.87% <0.00%> (-1.09%) ⬇️
go/runtime/host/sandbox/process/bwrap.go 63.82% <20.00%> (-2.47%) ⬇️
...nsensus/tendermint/apps/keymanager/transactions.go 0.00% <0.00%> (-52.95%) ⬇️
go/ias/http/http.go 18.51% <0.00%> (-44.45%) ⬇️
go/oasis-node/cmd/common/metrics/disk.go 65.38% <0.00%> (-19.24%) ⬇️
go/keymanager/api/policy_sgx.go 23.07% <0.00%> (-15.39%) ⬇️
go/runtime/host/sandbox/sandbox.go 69.76% <0.00%> (-11.25%) ⬇️
go/oasis-node/cmd/common/metrics/resource.go 78.94% <0.00%> (-10.53%) ⬇️
go/oasis-node/cmd/ias/auth.go 64.00% <0.00%> (-8.00%) ⬇️
...consensus/tendermint/apps/keymanager/keymanager.go 57.22% <0.00%> (-6.63%) ⬇️
... and 33 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ebd5673...1c5963f. Read the comment docs.

@kostko kostko enabled auto-merge July 6, 2021 16:52
@kostko kostko merged commit 09637a5 into master Jul 7, 2021
@kostko kostko deleted the kostko/fix/bwrap-add-timeout branch July 7, 2021 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Don't hang on old versions of bwrap
3 participants