Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go/consensus/tendermint: Correctly propagate errors #4110

Merged
merged 1 commit into from
Jul 4, 2021

Conversation

kostko
Copy link
Member

@kostko kostko commented Jul 3, 2021

Not propagating the state unavailable error could lead to corruption when the
database becomes unavailable (e.g., due to running out of space or file
descriptors).

@kostko kostko added c:consensus/cometbft Category: CometBFT c:bug Category: bug labels Jul 3, 2021
Not propagating the state unavailable error could lead to corruption when the
database becomes unavailable (e.g., due to running out of space or file
descriptors).
@kostko kostko force-pushed the kostko/fix/staking-propagate-err branch from 4da38b5 to f58415f Compare July 3, 2021 11:48
@codecov
Copy link

codecov bot commented Jul 3, 2021

Codecov Report

Merging #4110 (f58415f) into master (e85fcca) will decrease coverage by 0.58%.
The diff coverage is 68.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4110      +/-   ##
==========================================
- Coverage   67.09%   66.51%   -0.59%     
==========================================
  Files         410      410              
  Lines       42380    42391      +11     
==========================================
- Hits        28436    28195     -241     
- Misses       9964    10211     +247     
- Partials     3980     3985       +5     
Impacted Files Coverage Δ
go/consensus/tendermint/apps/staking/staking.go 52.79% <40.00%> (-0.08%) ⬇️
go/consensus/tendermint/apps/staking/votes.go 88.88% <71.42%> (-11.12%) ⬇️
...ensus/tendermint/apps/staking/proposing_rewards.go 83.78% <100.00%> (+0.92%) ⬆️
...nsensus/tendermint/apps/keymanager/transactions.go 0.00% <0.00%> (-52.95%) ⬇️
go/ias/http/http.go 18.51% <0.00%> (-44.45%) ⬇️
go/oasis-node/cmd/common/metrics/disk.go 65.38% <0.00%> (-19.24%) ⬇️
go/keymanager/api/policy_sgx.go 23.07% <0.00%> (-15.39%) ⬇️
go/runtime/host/sandbox/sandbox.go 70.54% <0.00%> (-11.25%) ⬇️
go/oasis-node/cmd/common/metrics/resource.go 78.94% <0.00%> (-10.53%) ⬇️
go/consensus/tendermint/abci/state/state.go 54.54% <0.00%> (-9.10%) ⬇️
... and 39 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e85fcca...f58415f. Read the comment docs.

@kostko kostko merged commit 1158d26 into master Jul 4, 2021
@kostko kostko deleted the kostko/fix/staking-propagate-err branch July 4, 2021 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c:bug Category: bug c:consensus/cometbft Category: CometBFT
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants