Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go/worker/storage: Add missing timeout for operations #4072

Merged
merged 2 commits into from
Jun 23, 2021

Conversation

kostko
Copy link
Member

@kostko kostko commented Jun 23, 2021

No description provided.

@kostko kostko requested review from ptrus and jberci June 23, 2021 13:57
@kostko kostko added c:bug Category: bug c:runtime Category: runtime c:storage Category: storage labels Jun 23, 2021
@codecov
Copy link

codecov bot commented Jun 23, 2021

Codecov Report

Merging #4072 (c9b2bf3) into master (ef23374) will decrease coverage by 0.85%.
The diff coverage is 100.00%.

❗ Current head c9b2bf3 differs from pull request most recent head af60961. Consider uploading reports for the commit af60961 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4072      +/-   ##
==========================================
- Coverage   67.16%   66.31%   -0.86%     
==========================================
  Files         411      411              
  Lines       42190    42197       +7     
==========================================
- Hits        28339    27983     -356     
- Misses       9873    10230     +357     
- Partials     3978     3984       +6     
Impacted Files Coverage Δ
go/worker/storage/committee/checkpoint_sync.go 77.89% <100.00%> (-0.34%) ⬇️
go/worker/storage/committee/node.go 79.32% <100.00%> (+0.06%) ⬆️
go/oasis-node/cmd/ias/auth_registry.go 0.00% <0.00%> (-67.13%) ⬇️
...nsensus/tendermint/apps/keymanager/transactions.go 0.00% <0.00%> (-52.95%) ⬇️
go/ias/http/http.go 18.51% <0.00%> (-44.45%) ⬇️
go/oasis-node/cmd/common/metrics/disk.go 65.38% <0.00%> (-19.24%) ⬇️
go/keymanager/api/policy_sgx.go 23.07% <0.00%> (-15.39%) ⬇️
go/oasis-node/cmd/common/metrics/resource.go 78.94% <0.00%> (-10.53%) ⬇️
go/runtime/host/sandbox/sandbox.go 69.76% <0.00%> (-10.47%) ⬇️
go/storage/api/root_cache.go 75.55% <0.00%> (-8.89%) ⬇️
... and 45 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ef23374...af60961. Read the comment docs.

@kostko kostko force-pushed the kostko/fix/missed-epoch-on-upgrade branch from c9b2bf3 to af60961 Compare June 23, 2021 15:57
@kostko kostko marked this pull request as ready for review June 23, 2021 15:58
@kostko kostko enabled auto-merge June 23, 2021 15:58
@kostko kostko merged commit 7da480c into master Jun 23, 2021
@kostko kostko deleted the kostko/fix/missed-epoch-on-upgrade branch June 23, 2021 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c:bug Category: bug c:runtime Category: runtime c:storage Category: storage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants