Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go/runtime/host/sandbox: Prevent restart storm after 10m #4059

Merged
merged 2 commits into from
Jun 21, 2021

Conversation

kostko
Copy link
Member

@kostko kostko commented Jun 21, 2021

Defaults bite again.

@kostko kostko added the c:bug Category: bug label Jun 21, 2021
@kostko kostko force-pushed the kostko/fix/rt-restart-backoff branch from 1509d0b to 8d3b1dd Compare June 21, 2021 11:43
@Yawning
Copy link
Contributor

Yawning commented Jun 21, 2021

Is there anywhere else we are doing this, and if so should we have helpers so this doesn't happen again?

@codecov
Copy link

codecov bot commented Jun 21, 2021

Codecov Report

Merging #4059 (8d3b1dd) into master (11d40b8) will decrease coverage by 1.07%.
The diff coverage is 0.00%.

❗ Current head 8d3b1dd differs from pull request most recent head 6d8c056. Consider uploading reports for the commit 6d8c056 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4059      +/-   ##
==========================================
- Coverage   67.42%   66.35%   -1.08%     
==========================================
  Files         410      410              
  Lines       42164    42166       +2     
==========================================
- Hits        28428    27978     -450     
- Misses       9790    10206     +416     
- Partials     3946     3982      +36     
Impacted Files Coverage Δ
go/runtime/host/sandbox/sandbox.go 70.00% <0.00%> (-11.01%) ⬇️
go/oasis-node/cmd/ias/auth_registry.go 0.00% <0.00%> (-67.13%) ⬇️
...nsensus/tendermint/apps/keymanager/transactions.go 0.00% <0.00%> (-52.95%) ⬇️
go/ias/http/http.go 18.51% <0.00%> (-44.45%) ⬇️
go/oasis-node/cmd/common/metrics/disk.go 65.38% <0.00%> (-19.24%) ⬇️
go/keymanager/api/policy_sgx.go 23.07% <0.00%> (-15.39%) ⬇️
go/oasis-node/cmd/common/metrics/resource.go 78.94% <0.00%> (-10.53%) ⬇️
go/consensus/tendermint/abci/state/state.go 54.54% <0.00%> (-9.10%) ⬇️
go/consensus/tendermint/apps/staking/auth.go 83.33% <0.00%> (-8.34%) ⬇️
... and 51 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 11d40b8...6d8c056. Read the comment docs.

@kostko
Copy link
Member Author

kostko commented Jun 21, 2021

Is there anywhere else we are doing this, and if so should we have helpers so this doesn't happen again?

Good idea, added our own helper and made sure we use it everywhere.

@kostko kostko enabled auto-merge June 21, 2021 13:39
@kostko kostko merged commit 30a66c9 into master Jun 21, 2021
@kostko kostko deleted the kostko/fix/rt-restart-backoff branch June 21, 2021 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c:bug Category: bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants