Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use typed attributes in registry and roothash services #4034

Closed
kostko opened this issue Jun 16, 2021 · 0 comments · Fixed by #4465
Closed

Use typed attributes in registry and roothash services #4034

kostko opened this issue Jun 16, 2021 · 0 comments · Fixed by #4465
Assignees
Labels
c:breaking Category: breaking code change c:consensus/cometbft Category: CometBFT c:registry Category: entity/node/runtime registry service c:roothash Category: root hash service

Comments

@kostko
Copy link
Member

kostko commented Jun 16, 2021

The new typed event attribute API introduced in #4033 makes it harder to mess up key/value pairs when emitting events. We should also change the remaining services (e.g., registry and roothash) to use it.

This requires changing some of the internal event types and is a breaking change (not consensus-breaking, but it requires nodes to resync from an empty state if they want to query events on old heights due to the event semantics changing).

@kostko kostko added c:roothash Category: root hash service c:registry Category: entity/node/runtime registry service c:consensus/cometbft Category: CometBFT c:breaking Category: breaking code change labels Jun 16, 2021
@kostko kostko changed the title Used typed attributes in registry and roothash services Use typed attributes in registry and roothash services Jun 30, 2021
@ptrus ptrus self-assigned this Jan 28, 2022
@ptrus ptrus linked a pull request Feb 7, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c:breaking Category: breaking code change c:consensus/cometbft Category: CometBFT c:registry Category: entity/node/runtime registry service c:roothash Category: root hash service
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants