go/consensus/api/transaction/testvector: Extend TestVector to suport the notion of a (statically) valid transaction #3845
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjanez
added
c:testing
tjanez
force-pushed
the
tjanez/testvector-valid
branch
3 times, most recently
from
717f602 to
9485e2b
Compare
tjanez
requested review from
kostko,
peterjgilbert,
pro-wh,
ptrus and
Yawning
as code owners
ptrus
reviewed
Apr 9, 2021
kostko
reviewed
Apr 9, 2021
ptrus
reviewed
Apr 9, 2021
tjanez
force-pushed
the
tjanez/testvector-valid
branch
4 times, most recently
from
47a5aa3 to
09415eb
Compare
This makes it consistent with how we usually order protocol versions in output and when initializing the ProtocolVersions struct.
tjanez
force-pushed
the
tjanez/testvector-valid
branch
from
09415eb to
a194c3c
Compare
kostko
reviewed
Apr 9, 2021
tjanez
force-pushed
the
tjanez/testvector-valid
branch
from
a194c3c to
a4631f5
Compare
He he, I didn't see that one comming 😄. I think it should be fixed now. |
|
Still failing due to invalid proposal. |
kostko
reviewed
Apr 10, 2021
Also drop entity from {min,max}EntityDescriptorVersion constants.
The entity part was redundant.
tjanez
force-pushed
the
tjanez/testvector-valid
branch
from
a4631f5 to
1dc7054
Compare
Extend meaning of TestVector's Valid field to also indicate that the given test vector's transaction passes basic static validation (besides having a valid signature and being correctly serialized). Update MakeTestVector() and MakeTestVectorWithSigner() functions to take the valid argument indicating whether the transaction is valid or not. Update go/registry/gen_vectors, go/staking/gen_vectors and go/governance/gen_vectors packages. Expand go/governance/gen_vectors package to cover more (invalid) transaction cases.
tjanez
force-pushed
the
tjanez/testvector-valid
branch
from
1dc7054 to
3313495
Compare
kostko
approved these changes
Apr 10, 2021
Codecov Report
@@ Coverage Diff @@
## master #3845 +/- ##
==========================================
- Coverage 67.14% 66.96% -0.19%
==========================================
Files 404 404
Lines 41428 41448 +20
==========================================
- Hits 27816 27754 -62
- Misses 9678 9744 +66
- Partials 3934 3950 +16
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.