Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go/upgrade/api: simplify upgrade descriptor #3793

Merged
merged 2 commits into from
Mar 17, 2021

Conversation

ptrus
Copy link
Member

@ptrus ptrus commented Mar 17, 2021

No description provided.

@ptrus ptrus force-pushed the ptrus/fix/simplfy-ugprade-descriptor branch 2 times, most recently from 67d9f35 to 9174bd5 Compare March 17, 2021 18:01
@ptrus ptrus force-pushed the ptrus/fix/simplfy-ugprade-descriptor branch from 9174bd5 to e176ed9 Compare March 17, 2021 19:25
@ptrus ptrus marked this pull request as ready for review March 17, 2021 19:29
@codecov
Copy link

codecov bot commented Mar 17, 2021

Codecov Report

Merging #3793 (461889e) into master (a39d1e1) will increase coverage by 0.15%.
The diff coverage is 62.85%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3793      +/-   ##
==========================================
+ Coverage   67.20%   67.35%   +0.15%     
==========================================
  Files         404      404              
  Lines       40882    40851      -31     
==========================================
+ Hits        27473    27515      +42     
+ Misses       9522     9468      -54     
+ Partials     3887     3868      -19     
Impacted Files Coverage Δ
go/common/version/version.go 80.48% <0.00%> (-0.91%) ⬇️
go/governance/api/sanity_check.go 88.73% <0.00%> (ø)
go/oasis-node/cmd/common/common.go 48.78% <50.00%> (-0.82%) ⬇️
go/oasis-node/cmd/root.go 85.71% <50.00%> (-2.53%) ⬇️
go/upgrade/upgrade.go 59.31% <60.00%> (ø)
go/upgrade/api/api.go 87.50% <80.00%> (-5.73%) ⬇️
go/governance/tests/tester.go 86.61% <83.33%> (-0.06%) ⬇️
go/upgrade/migrations/dummy.go 70.00% <100.00%> (ø)
go/consensus/tendermint/full/services.go 80.00% <0.00%> (-4.17%) ⬇️
go/consensus/tendermint/apps/beacon/state/state.go 68.25% <0.00%> (-3.18%) ⬇️
... and 31 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a39d1e1...461889e. Read the comment docs.

@ptrus ptrus merged commit 48d14f0 into master Mar 17, 2021
@ptrus ptrus deleted the ptrus/fix/simplfy-ugprade-descriptor branch March 17, 2021 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants