Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go/upgrade/api: Version upgrade Descriptors #3781

Merged
merged 2 commits into from
Mar 16, 2021

Conversation

ptrus
Copy link
Member

@ptrus ptrus commented Mar 15, 2021

Fixes: #3770

@codecov
Copy link

codecov bot commented Mar 15, 2021

Codecov Report

Merging #3781 (bb90111) into master (3679481) will increase coverage by 0.08%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3781      +/-   ##
==========================================
+ Coverage   67.28%   67.36%   +0.08%     
==========================================
  Files         402      402              
  Lines       40551    40560       +9     
==========================================
+ Hits        27283    27325      +42     
+ Misses       9415     9394      -21     
+ Partials     3853     3841      -12     
Impacted Files Coverage Δ
go/governance/tests/tester.go 86.66% <100.00%> (+0.05%) ⬆️
go/upgrade/api/api.go 93.22% <100.00%> (+0.91%) ⬆️
go/upgrade/upgrade.go 59.31% <100.00%> (+0.28%) ⬆️
go/oasis-node/cmd/common/metrics/disk.go 65.38% <0.00%> (-19.24%) ⬇️
go/consensus/tendermint/apps/governance/query.go 83.33% <0.00%> (-16.67%) ⬇️
go/oasis-node/cmd/common/metrics/resource.go 78.94% <0.00%> (-10.53%) ⬇️
go/worker/upgrade/worker.go 64.35% <0.00%> (-4.96%) ⬇️
go/storage/api/root_cache.go 75.55% <0.00%> (-4.45%) ⬇️
go/consensus/tendermint/full/services.go 80.00% <0.00%> (-4.17%) ⬇️
go/consensus/tendermint/apps/beacon/state/state.go 71.42% <0.00%> (-3.18%) ⬇️
... and 31 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3679481...bb90111. Read the comment docs.

@ptrus ptrus force-pushed the ptrus/feature/versioned-upgrade-descriptors branch from c9b8320 to bb90111 Compare March 16, 2021 08:29
@ptrus ptrus marked this pull request as ready for review March 16, 2021 08:29
@ptrus ptrus merged commit 7d0d54b into master Mar 16, 2021
@ptrus ptrus deleted the ptrus/feature/versioned-upgrade-descriptors branch March 16, 2021 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Version upgrade.Descriptor and upgrader.PendingUpgrade structs
2 participants