Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runtime: Use Namespace for runtime id, validate block namespace #3633

Merged
merged 2 commits into from
Jan 15, 2021

Conversation

kostko
Copy link
Member

@kostko kostko commented Jan 15, 2021

  • runtime: Remove common::runtime::RuntimeId

    The Go API has been using Namespace for a while so this makes it
    consistent in the Rust runtime as well.

  • runtime: Validate block namespace against runtime ID

The Go API has been using Namespace for a while so this makes it
consistent in the Rust runtime as well.
@kostko kostko force-pushed the kostko/feature/rt-id-namespace branch from 08a365e to d724832 Compare January 15, 2021 11:54
@codecov
Copy link

codecov bot commented Jan 15, 2021

Codecov Report

Merging #3633 (d724832) into master (ef294fb) will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3633      +/-   ##
==========================================
- Coverage   67.36%   67.33%   -0.03%     
==========================================
  Files         390      390              
  Lines       36676    36676              
==========================================
- Hits        24706    24696      -10     
- Misses       8523     8531       +8     
- Partials     3447     3449       +2     
Impacted Files Coverage Δ
go/consensus/tendermint/full/services.go 81.35% <0.00%> (-4.24%) ⬇️
go/runtime/host/protocol/connection.go 57.55% <0.00%> (-4.09%) ⬇️
go/worker/keymanager/worker.go 61.06% <0.00%> (-2.81%) ⬇️
go/consensus/tendermint/apps/registry/genesis.go 39.80% <0.00%> (-1.95%) ⬇️
go/runtime/nodes/versioned.go 75.23% <0.00%> (-1.91%) ⬇️
go/worker/common/committee/runtime_host.go 64.28% <0.00%> (-1.79%) ⬇️
go/runtime/client/watcher.go 62.96% <0.00%> (-1.49%) ⬇️
.../consensus/tendermint/apps/registry/state/state.go 57.75% <0.00%> (-1.33%) ⬇️
go/consensus/api/grpc.go 69.27% <0.00%> (-1.16%) ⬇️
go/registry/api/api.go 49.20% <0.00%> (-1.07%) ⬇️
... and 22 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ef294fb...d724832. Read the comment docs.

@kostko kostko merged commit a235ca4 into master Jan 15, 2021
@kostko kostko deleted the kostko/feature/rt-id-namespace branch January 15, 2021 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants