Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go/worker/p2p: Include new peers from received node list #3378

Merged
merged 1 commit into from
Oct 6, 2020

Conversation

ptrus
Copy link
Member

@ptrus ptrus commented Oct 6, 2020

Previously we only removed peers and updated existing peers from the received node list - therefore a node restarting in the middle of an epoch did not actually connect to all of the nodes until the next epoch transition (it only connected to the nodes that did an update mid-epoch - which triggered a WatchNodes event).

Discovered while testing #3322

@ptrus ptrus force-pushed the ptrus/fix/peermgr-nodelist branch 2 times, most recently from cbb47fe to a7965fc Compare October 6, 2020 11:42
@ptrus ptrus force-pushed the ptrus/fix/peermgr-nodelist branch from a7965fc to 443ea36 Compare October 6, 2020 11:45
@codecov
Copy link

codecov bot commented Oct 6, 2020

Codecov Report

Merging #3378 into master will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3378      +/-   ##
==========================================
- Coverage   66.12%   66.11%   -0.01%     
==========================================
  Files         370      370              
  Lines       33228    33228              
==========================================
- Hits        21971    21969       -2     
- Misses       8020     8030      +10     
+ Partials     3237     3229       -8     
Impacted Files Coverage Δ
go/worker/common/p2p/peermgmt.go 72.64% <ø> (ø)
go/worker/compute/executor/committee/state.go 71.42% <0.00%> (-14.29%) ⬇️
go/consensus/tendermint/api/api.go 74.66% <0.00%> (-10.67%) ⬇️
go/worker/storage/committee/checkpoint_sync.go 74.53% <0.00%> (-3.70%) ⬇️
go/worker/common/committee/node.go 74.86% <0.00%> (-2.80%) ⬇️
go/consensus/tendermint/roothash/roothash.go 70.15% <0.00%> (-2.16%) ⬇️
go/worker/compute/executor/committee/node.go 62.19% <0.00%> (-1.24%) ⬇️
go/runtime/client/watcher.go 66.66% <0.00%> (-1.12%) ⬇️
go/runtime/client/client.go 65.40% <0.00%> (-0.95%) ⬇️
go/storage/api/grpc.go 68.28% <0.00%> (-0.89%) ⬇️
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0d0f3c9...443ea36. Read the comment docs.

@ptrus ptrus merged commit 5ceb5b8 into master Oct 6, 2020
@ptrus ptrus deleted the ptrus/fix/peermgr-nodelist branch October 6, 2020 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants