Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix fuzz-build #3374

Closed
kostko opened this issue Oct 5, 2020 · 3 comments · Fixed by #3521
Closed

Fix fuzz-build #3374

kostko opened this issue Oct 5, 2020 · 3 comments · Fixed by #3521
Labels
c:bug Category: bug c:build Category: build environment c:testing Category: testing

Comments

@kostko
Copy link
Member

kostko commented Oct 5, 2020

It seems that the make -C go fuzz-build target doesn't actually build in latest master, but for some reason CI is passing despite the build errors.
@kostko kostko added c:testing Category: testing c:build Category: build environment c:bug Category: bug labels Oct 5, 2020
@kostko
Copy link
Member Author

kostko commented Oct 5, 2020 •
edited
Loading

Some failures seems to be due to dvyukov/go-fuzz#294 on Go 1.15.

@jberci
Copy link
Contributor

jberci commented Oct 5, 2020

The makefile changes are in #3373, but for the go-fuzz bug we'll need to wait. Until then, the pipeline step has a soft_fail.

@kostko kostko added the s:blocked Status: blocked on other work label Oct 13, 2020
@kostko
Copy link
Member Author

kostko commented Nov 16, 2020

It seems upstream has been fixed.

@kostko kostko removed the s:blocked Status: blocked on other work label Nov 16, 2020
@kostko kostko mentioned this issue Nov 16, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c:bug Category: bug c:build Category: build environment c:testing Category: testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ci: Make build-fuzz failures fatal now that upstream is fixed oasisprotocol/oasis-core
2 participants
@kostko @jberci