Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go/worker/storage: Always use fresh nodes for policy updates #3252

Merged
merged 1 commit into from
Sep 8, 2020

Conversation

kostko
Copy link
Member

@kostko kostko commented Sep 8, 2020

No description provided.

@kostko kostko added c:storage Category: storage c:bug Category: bug labels Sep 8, 2020
@kostko kostko force-pushed the kostko/fix/storage-policy-update branch from ee367fb to 3ac27e2 Compare September 8, 2020 11:31
@codecov
Copy link

codecov bot commented Sep 8, 2020

Codecov Report

Merging #3252 into master will decrease coverage by 0.19%.
The diff coverage is 63.35%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3252      +/-   ##
==========================================
- Coverage   67.67%   67.48%   -0.20%     
==========================================
  Files         370      370              
  Lines       36330    36449     +119     
==========================================
+ Hits        24586    24597      +11     
- Misses       8584     8674      +90     
- Partials     3160     3178      +18     
Impacted Files Coverage Δ
go/worker/common/worker.go 90.83% <ø> (+1.52%) ⬆️
go/scheduler/api/api.go 53.84% <34.61%> (-17.35%) ⬇️
go/oasis-node/cmd/node/node.go 55.71% <41.17%> (-0.11%) ⬇️
go/control/control.go 52.85% <50.00%> (-0.18%) ⬇️
go/oasis-node/cmd/node/control.go 51.94% <53.57%> (+4.32%) ⬆️
go/worker/common/p2p/p2p.go 70.79% <75.00%> (+0.32%) ⬆️
go/worker/common/committee/group.go 80.09% <85.71%> (+0.84%) ⬆️
...o/consensus/tendermint/apps/scheduler/scheduler.go 66.57% <100.00%> (-1.69%) ⬇️
go/roothash/api/commitment/pool.go 73.57% <100.00%> (ø)
go/roothash/tests/tester.go 89.25% <100.00%> (ø)
... and 28 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a72b9bb...3ac27e2. Read the comment docs.

@ptrus
Copy link
Member

ptrus commented Sep 8, 2020

Btw is there a way to disable specifically the "Unchanged files with check annotations" from codecov. I think the annotations for files that weren't changed in a PR don't make that much sense.

@kostko
Copy link
Member Author

kostko commented Sep 8, 2020

Btw is there a way to disable specifically the "Unchanged files with check annotations" from codecov. I think the annotations for files that weren't changed in a PR don't make that much sense.

Agreed, but I don't see that option, it seems you can only disable all annotations.

@kostko kostko merged commit a2ee9ba into master Sep 8, 2020
@kostko kostko deleted the kostko/fix/storage-policy-update branch September 8, 2020 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c:bug Category: bug c:storage Category: storage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants