Unify pretty printing of quantity.Quantity fractions #3129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjanez
requested review from
kostko,
peterjgilbert,
pro-wh and
Yawning
as code owners
tjanez
force-pushed
the
tjanez/prettier-unify-frac-comp
branch
2 times, most recently
from
d825fd2 to
6f38b2e
Compare
Set its base-10 exponent in commissionRateDenominatorExponent and use it to compute the CommissionRateDenominator.
Make ConvertToTokenAmount() and PrettyPrintCommissionRatePercentage() use the newly introduced FractionBase10 function. Add tests for PrettyPrintCommissionRatePercentage() and move it to go/staking/api/prettyprint.go.
tjanez
force-pushed
the
tjanez/prettier-unify-frac-comp
branch
from
6f38b2e to
ae3c937
Compare
Codecov Report
@@ Coverage Diff @@
## master #3129 +/- ##
==========================================
+ Coverage 68.89% 68.98% +0.08%
==========================================
Files 373 374 +1
Lines 36986 36990 +4
==========================================
+ Hits 25481 25516 +35
+ Misses 8258 8235 -23
+ Partials 3247 3239 -8
Continue to review full report at Codecov.
|
tjanez
commented
Jul 24, 2020
|
|
||
| // FractionBase10 returns a decimal representation of a fraction from fraction's | ||
| // numerator and denominator's base-10 exponent. | ||
| func FractionBase10(numerator quantity.Quantity, denominatorExp uint8) string { |
There was a problem hiding this comment.
Another idea for the name is QuantityFraction()...
kostko
approved these changes
Jul 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.