Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure TendermintService is only used internally #3115

Closed
Tracked by #2440
kostko opened this issue Jul 19, 2020 · 0 comments · Fixed by #3126
Closed
Tracked by #2440

Make sure TendermintService is only used internally #3115

kostko opened this issue Jul 19, 2020 · 0 comments · Fixed by #3126
Assignees
@kostko
Labels
c:consensus/cometbft Category: CometBFT

Comments

@kostko
Copy link
Member

kostko commented Jul 19, 2020

Currently calling tendermint.New on the Tendermint consensus package returns a TendermintService interface which exposes some internal methods. We should refactor this to return a generic consensus.Backend instead and make sure the internal methods are not exposed.
@kostko kostko added the c:consensus/cometbft Category: CometBFT label Jul 19, 2020
@kostko kostko self-assigned this Jul 19, 2020
This was referenced Jul 19, 2020
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kostko kostko

Labels
c:consensus/cometbft Category: CometBFT
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Cleanup Tendermint consensus backend oasisprotocol/oasis-core
1 participant
@kostko