go/common/crypto/signature/signers/ledger: Descriptive error on user reject #3050
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjanez
requested review from
kostko,
peterjgilbert,
pro-wh and
Yawning
as code owners
kostko
reviewed
Jun 25, 2020
tjanez
force-pushed
the
tjanez/ledger-err-reject-tx
branch
2 times, most recently
from
a92a699 to
639a1b5
Compare
tjanez
changed the title
kostko
reviewed
Jun 25, 2020
| return s.device.SignEd25519(s.path, preparedContext, message) | ||
| signature, err := s.device.SignEd25519(s.path, preparedContext, message) | ||
| if err != nil { | ||
| if err.Error() == ledgerRejectTxErrorMsg { |
There was a problem hiding this comment.
Maybe use errors.Is instead. Also consider using a switch statement instead of these nested ifs.
There was a problem hiding this comment.
I've removed nested ifs and used a switch statement.
I couldn't use errors.Is() because at the moment, ledger-go doesn't use proper Go error semantics and doesn't expose errors as variables.
Codecov Report
@@ Coverage Diff @@
## master #3050 +/- ##
==========================================
- Coverage 68.27% 68.23% -0.04%
==========================================
Files 372 372
Lines 36437 36444 +7
==========================================
- Hits 24877 24868 -9
- Misses 8346 8365 +19
+ Partials 3214 3211 -3
Continue to review full report at Codecov.
|
tjanez
force-pushed
the
tjanez/ledger-err-reject-tx
branch
from
639a1b5 to
a0b89d7
Compare
Make Ledger signer return a more descriptive error message when a user rejects a transaction on the Ledger device.
tjanez
force-pushed
the
tjanez/ledger-err-reject-tx
branch
from
a0b89d7 to
bb7fbe7
Compare
kostko
approved these changes
Jun 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make Ledger signer return a more descriptive error message when a user rejects a transaction on the Ledger device.
For example, previously, the returned error was:
Now, it is: