Change Account ids/addresses to truncated hash of the public key #2940

tjanez · 2020-05-26T12:04:29Z

Closes #2928.

TODO:

Use Bech32-encoding for marshaling/unmarshaling addresses to/from their text form.
Implement address context separation in the form of H(<context> || <pubkey>), e.g. H("oasis-core/address: staking" || <pubkey>).
Add versioning to Account addresses.
Implement a notion of reserved addresses.
Add staking transaction checks for reserved addresses.
Choose Oasis staking account address Bech32 human readable part.
Fix E2E tests.

go/common/crypto/address/address.go

Yawning · 2020-05-26T14:16:31Z

go/common/crypto/address/address.go

@@ -0,0 +1,80 @@
+// Package address implements a generic cryptographic address.


A better description would be nice.

I tried, please take another look.

@Yawning, ping

go/common/crypto/address/address.go

go/consensus/tendermint/apps/scheduler/scheduler.go

go/consensus/tendermint/apps/keymanager/keymanager.go

go/staking/api/api.go

go/staking/api/address.go

go/common/crypto/address/version.go

go/common/crypto/address/address.go

go/common/crypto/address/context.go

go/consensus/tendermint/apps/scheduler/scheduler.go

kostko

Don't forget to mention all the API and config parameter changes in the respective changelog fragments.

go/consensus/tendermint/apps/staking/query.go

go/staking/api/api.go

go/consensus/tendermint/apps/staking/signing_rewards.go

go/consensus/tendermint/apps/staking/state/gas.go

go/oasis-test-runner/scenario/e2e/gas_fees_staking.go

go/staking/api/api.go

kostko

Looked at the recent Bech32 registration addition, looks good!

go/common/crypto/address/bech32.go

go/common/crypto/address/address.go

go/common/crypto/address/context.go

go/common/crypto/address/bech32.go

go/common/crypto/hash/hash.go

go/consensus/tendermint/apps/staking/state/gas.go

go/common/crypto/hash/hash.go

Rename NewBlacklistedKey() to NewBlacklistedPublicKey() for consistency. Update the tests to cover these two functions.

Add OwnTxSignerAddress() to ApplicationState.

The test scenario that used it was removed when support for v0 node descriptor was removed in #2963.

tests/fixture-data: Update genesis documents to use the new staking account address format.

Replace GetSignerNonceRequest's ID field with AccountAddress field to reflect the recent staking account id/address change.

Rename EstimateGasRequest's Caller field to Signer to better describe the field's value which is the public key of the transaction's signer.

Yawning reviewed May 26, 2020

View reviewed changes

Yawning mentioned this pull request May 29, 2020

go/consensus/genesis: Add a public key blacklist #2959

Merged

4 tasks

tjanez force-pushed the tjanez/new-account-ids branch from 3649ad6 to 86e1bed Compare May 29, 2020 12:05

tjanez changed the title ~~Change Account ids to truncated hash of the public key~~ Change Account ids/addresses to truncated hash of the public key May 29, 2020

tjanez force-pushed the tjanez/new-account-ids branch from 86e1bed to 88954c5 Compare May 29, 2020 12:53

kostko reviewed May 29, 2020

View reviewed changes

go/consensus/tendermint/apps/keymanager/keymanager.go Outdated Show resolved Hide resolved

kostko reviewed May 29, 2020

View reviewed changes

go/staking/api/api.go Outdated Show resolved Hide resolved

tjanez force-pushed the tjanez/new-account-ids branch 8 times, most recently from 97b9716 to 20554a5 Compare June 3, 2020 15:50

tjanez commented Jun 3, 2020

View reviewed changes

go/staking/api/address.go Outdated Show resolved Hide resolved

tjanez force-pushed the tjanez/new-account-ids branch 2 times, most recently from 6e46fc3 to ea9cec4 Compare June 3, 2020 16:32

kostko reviewed Jun 3, 2020

View reviewed changes

go/common/crypto/address/version.go Outdated Show resolved Hide resolved

go/common/crypto/address/version.go Outdated Show resolved Hide resolved

tjanez force-pushed the tjanez/new-account-ids branch 4 times, most recently from 6cb53bf to 951b70e Compare June 4, 2020 12:43

kostko reviewed Jun 4, 2020

View reviewed changes

tjanez force-pushed the tjanez/new-account-ids branch from 951b70e to 05ca1e6 Compare June 5, 2020 08:29

kostko reviewed Jun 5, 2020

View reviewed changes

tjanez force-pushed the tjanez/new-account-ids branch from 05ca1e6 to 0787fc7 Compare June 5, 2020 16:35

kostko reviewed Jun 8, 2020

View reviewed changes

go/common/crypto/address/bech32.go Outdated Show resolved Hide resolved

kostko reviewed Jun 8, 2020

View reviewed changes

go/common/crypto/address/address.go Outdated Show resolved Hide resolved

tjanez force-pushed the tjanez/new-account-ids branch from 0787fc7 to f446c78 Compare June 8, 2020 12:34

kostko approved these changes Jun 10, 2020

View reviewed changes

Yawning reviewed Jun 10, 2020

View reviewed changes

go/common/crypto/address/context.go Outdated Show resolved Hide resolved

go/common/crypto/address/bech32.go Outdated Show resolved Hide resolved

go/common/crypto/hash/hash.go Outdated Show resolved Hide resolved

go/consensus/tendermint/apps/staking/state/gas.go Show resolved Hide resolved

kostko reviewed Jun 10, 2020

View reviewed changes

go/common/crypto/hash/hash.go Outdated Show resolved Hide resolved

go/common/encoding: Add bech32 package implementing Bech32 encoding

422059e

tjanez force-pushed the tjanez/new-account-ids branch 2 times, most recently from fd9df12 to 7c44974 Compare June 11, 2020 08:53

kostko approved these changes Jun 11, 2020

View reviewed changes

tjanez added 15 commits June 11, 2020 13:06

go/common/crypto/hash: Add Truncate() method to Hash

fcef963

go/common/crypto/signature: Add NewPublicKey() function

08f0b2d

Rename NewBlacklistedKey() to NewBlacklistedPublicKey() for consistency. Update the tests to cover these two functions.

go/common/crypto/signature: Use one-line if in PublicKey's BlackList()

1eb4b78

go/common/crypto: Add address package implementing a generic address

01c769a

go/staking/api: Add Address for representing staking account addresses

f30c411

go/consensus/tendermint/api: Add OwnTxSignerAddress() to app state

5501d83

Add OwnTxSignerAddress() to ApplicationState.

test/fixture-data/restore-previous: Remove obsolete genesis-v20.6.json

c5e8cc3

The test scenario that used it was removed when support for v0 node descriptor was removed in #2963.

tests/fixture-data/consim: Convert genesis.json to pretty-printed one

b62157a

go: Transition staking code to use go/staking/api.Address

c75f4b9

tests/fixture-data: Update genesis documents to use the new staking account address format.

go/consensus/tendermint/apps/staking: Forbid txs for reserved addresses

2c3e2f2

go/staking: Forbid reserved addresses in the Genesis

41db13f

go/staking/api: Rename Accounts()/AccountInfo() > Addresses()/Account()

bf6d558

go/oasis-node/cmd/node: Make initGenesis()' errors more descriptive

0e9f602

go/consensus/api: Use staking.Address in GetSignerNonceRequest type

3eb688f

Replace GetSignerNonceRequest's ID field with AccountAddress field to reflect the recent staking account id/address change.

go/consensus/api: Rename Caller field in EstimateGasRequest type

cd71625

Rename EstimateGasRequest's Caller field to Signer to better describe the field's value which is the public key of the transaction's signer.

tjanez force-pushed the tjanez/new-account-ids branch from 7c44974 to cd71625 Compare June 11, 2020 11:07

abukosek mentioned this pull request Jun 11, 2020

Transition to new account address format and encoding (Bech32 encoding) oasisprotocol/oasis-rosetta-gateway#6

Closed

tjanez merged commit 46fb6e5 into master Jun 11, 2020

tjanez deleted the tjanez/new-account-ids branch June 11, 2020 11:53

tjanez mentioned this pull request Jun 17, 2020

Add support for specifying and displaying Bech32-encoded account ids #2870

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Change Account ids/addresses to truncated hash of the public key #2940

Change Account ids/addresses to truncated hash of the public key #2940

tjanez commented May 26, 2020 •

edited

Loading

Yawning May 26, 2020

tjanez Jun 3, 2020

tjanez Jun 10, 2020

kostko left a comment

kostko left a comment

		@@ -0,0 +1,80 @@
		// Package address implements a generic cryptographic address.

Change Account ids/addresses to truncated hash of the public key #2940

Change Account ids/addresses to truncated hash of the public key #2940

Conversation

tjanez commented May 26, 2020 • edited Loading

Yawning May 26, 2020

Choose a reason for hiding this comment

tjanez Jun 3, 2020

Choose a reason for hiding this comment

tjanez Jun 10, 2020

Choose a reason for hiding this comment

kostko left a comment

Choose a reason for hiding this comment

kostko left a comment

Choose a reason for hiding this comment

tjanez commented May 26, 2020 •

edited

Loading