go/epochtime: add WatchLatestEpoch method #2876
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ptrus
requested review from
kostko,
peterjgilbert,
pro-wh and
Yawning
as code owners
ptrus
force-pushed
the
ptrus/feature/pubsub-configurable-chan
branch
3 times, most recently
from
39a1654 to
472acad
Compare
Codecov Report
@@ Coverage Diff @@
## master #2876 +/- ##
==========================================
+ Coverage 67.62% 67.67% +0.04%
==========================================
Files 344 344
Lines 33623 33652 +29
==========================================
+ Hits 22739 22773 +34
+ Misses 7974 7946 -28
- Partials 2910 2933 +23
Continue to review full report at Codecov.
|
kostko
approved these changes
Apr 29, 2020
Pubsub framework is extended to support subscriptions based on bounded ring channels. Bounded subscriptions are used in the new epochtime WatchLatestEpoch method. The method is similar to the existing WatchEpochs method, with the change that unread epochs get overridden with latest epoch. Registration worker is changed to use the WatchLatestEpoch method to prevent trying to register for old epochs in case the worker falls behind.
ptrus
force-pushed
the
ptrus/feature/pubsub-configurable-chan
branch
from
472acad to
cbf0a60
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #2862
Pubsub framework is extended to support subscriptions based on bounded
ring channels. Bounded subscriptions are used in the new epochtime
WatchLatestEpoch method. The method is similar to the existing WatchEpochs
method, with the change that unread epochs get overridden with latest
epoch.
Registration worker is changed to use the WatchLatestEpoch method to
prevent trying to register for old epochs in case the worker falls
behind.
XXX: any other places where using a ring channel (e.g. skipping past/outdated channel items) would be preferable?