Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go/storage/client: Don't treat "no nodes" as a permanent error #2785

Merged
merged 1 commit into from
Mar 26, 2020

Conversation

kostko
Copy link
Member

@kostko kostko commented Mar 26, 2020

No description provided.

@kostko kostko force-pushed the kostko/fix/storage-noconn-perm branch from 8d42bde to a737753 Compare March 26, 2020 09:39
@codecov
Copy link

codecov bot commented Mar 26, 2020

Codecov Report

Merging #2785 into master will decrease coverage by 0.12%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2785      +/-   ##
==========================================
- Coverage   62.95%   62.83%   -0.13%     
==========================================
  Files         389      389              
  Lines       37077    37080       +3     
==========================================
- Hits        23343    23299      -44     
- Misses      10739    10801      +62     
+ Partials     2995     2980      -15     
Impacted Files Coverage Δ
go/storage/client/client.go 76.76% <100.00%> (-0.13%) ⬇️
...oasis-node/cmd/debug/txsource/workload/transfer.go 0.00% <0.00%> (-63.81%) ⬇️
...ompute/txnscheduler/algorithm/batching/batching.go 78.66% <0.00%> (-6.67%) ⬇️
go/consensus/tendermint/roothash/roothash.go 65.54% <0.00%> (-6.00%) ⬇️
go/runtime/tagindexer/tagindexer.go 68.47% <0.00%> (-4.35%) ⬇️
go/worker/common/p2p/p2p.go 64.41% <0.00%> (-3.16%) ⬇️
go/runtime/transaction/transaction.go 75.90% <0.00%> (-2.41%) ⬇️
go/worker/compute/txnscheduler/committee/node.go 60.18% <0.00%> (-2.17%) ⬇️
go/storage/mkvs/urkel/iterator.go 84.37% <0.00%> (-1.25%) ⬇️
go/worker/common/committee/group.go 80.32% <0.00%> (-0.66%) ⬇️
... and 20 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f72c3ea...a737753. Read the comment docs.

@kostko kostko merged commit 504394e into master Mar 26, 2020
@kostko kostko deleted the kostko/fix/storage-noconn-perm branch March 26, 2020 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants