Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go/staking: include LastBlockFees in genesis #2777

Merged
merged 3 commits into from
Mar 26, 2020

Conversation

ptrus
Copy link
Member

@ptrus ptrus commented Mar 24, 2020

Also adds a dump-restore version of the gas-fees test.

@ptrus ptrus force-pushed the ptrus/feature/lastblockfees-genesis branch 2 times, most recently from 3cfe75d to ae6301e Compare March 24, 2020 09:32
@codecov
Copy link

codecov bot commented Mar 24, 2020

Codecov Report

Merging #2777 into master will increase coverage by 0.73%.
The diff coverage is 43.75%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2777      +/-   ##
==========================================
+ Coverage   62.44%   63.18%   +0.73%     
==========================================
  Files         389      389              
  Lines       37088    37119      +31     
==========================================
+ Hits        23159    23452     +293     
+ Misses      10969    10667     -302     
- Partials     2960     3000      +40     
Impacted Files Coverage Δ
...nsus/tendermint/apps/supplementarysanity/checks.go 47.85% <0.00%> (ø)
go/staking/api/api.go 71.42% <ø> (ø)
go/staking/api/sanity_check.go 50.87% <33.33%> (-0.48%) ⬇️
go/consensus/tendermint/apps/staking/genesis.go 43.86% <40.90%> (-0.35%) ⬇️
go/oasis-node/cmd/stake/stake.go 71.54% <66.66%> (-0.26%) ⬇️
...ompute/txnscheduler/algorithm/batching/batching.go 78.66% <0.00%> (-6.67%) ⬇️
go/worker/storage/service_external.go 47.31% <0.00%> (-4.31%) ⬇️
go/worker/common/p2p/p2p.go 64.86% <0.00%> (-2.71%) ⬇️
go/worker/storage/committee/checkpointer.go 66.37% <0.00%> (-1.77%) ⬇️
go/storage/mkvs/urkel/cache.go 81.27% <0.00%> (-1.71%) ⬇️
... and 28 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b4546d5...d964f30. Read the comment docs.

@Yawning
Copy link
Contributor

Yawning commented Mar 24, 2020

Will this break dump/restore?

@ptrus
Copy link
Member Author

ptrus commented Mar 24, 2020

yeah in the first begin block the GetLastCommitInfo will have no votes, so we probably need to also carry over that as well? (or handle differently the initial fee disbursement)

edit: one option moving it into common pool at initialization, this is what is currently implemented in the PR

@ptrus ptrus force-pushed the ptrus/feature/lastblockfees-genesis branch 8 times, most recently from 3d78d31 to b53b11b Compare March 25, 2020 11:48
@ptrus ptrus marked this pull request as ready for review March 25, 2020 11:51
@ptrus ptrus force-pushed the ptrus/feature/lastblockfees-genesis branch from f6bfcd5 to e4f8900 Compare March 25, 2020 16:56
@ptrus ptrus force-pushed the ptrus/feature/lastblockfees-genesis branch 2 times, most recently from c4ea829 to ae807e3 Compare March 26, 2020 08:47
@ptrus ptrus added the c:staking Category: staking label Mar 26, 2020
@ptrus ptrus force-pushed the ptrus/feature/lastblockfees-genesis branch 2 times, most recently from 2ef6cc2 to 3321963 Compare March 26, 2020 10:06
@ptrus ptrus force-pushed the ptrus/feature/lastblockfees-genesis branch from 3321963 to d964f30 Compare March 26, 2020 14:15
@ptrus ptrus merged commit 95b6fc1 into master Mar 26, 2020
@ptrus ptrus deleted the ptrus/feature/lastblockfees-genesis branch March 26, 2020 15:08
@ptrus ptrus self-assigned this Mar 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c:staking Category: staking
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants