Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Gluten-147] Made the needed changes to update Velox #144

Merged
merged 4 commits into from
May 9, 2022

Conversation

rui-mo
Copy link
Contributor

@rui-mo rui-mo commented May 7, 2022

What changes were proposed in this pull request?

  • Changed the Substrait plan generation logic when an pre-project is needed in aggregation. Unique columns will be selected by pre-projection.
  • Supported cast node.
  • Updated the docs.

After this change, Gluten will depend on the Velox under oap-project.

Fixed #147.

How was this patch tested?

locally verified

@github-actions
Copy link

github-actions bot commented May 7, 2022

Thanks for opening a pull request!

Could you open an issue for this pull request on Github Issues?

https://github.com/oap-project/gluten/issues

Then could you also rename commit message and pull request title in the following format?

[Gluten-${ISSUES_ID}] ${detailed message}

See also:

@rui-mo rui-mo changed the title Made the needed changes to update Velox [Gluten-147] Made the needed changes to update Velox May 7, 2022
@github-actions
Copy link

github-actions bot commented May 7, 2022

#147

Copy link
Contributor

@zzcclp zzcclp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, verified locally with clickhouse backend.

@zzcclp zzcclp merged commit de7aaa9 into apache:main May 9, 2022
@rui-mo rui-mo deleted the update branch March 14, 2023 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Velox
2 participants