Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support metadata in ns for require lines #125

Open
oakmac opened this issue Oct 17, 2024 · 2 comments
Open

support metadata in ns for require lines #125

oakmac opened this issue Oct 17, 2024 · 2 comments
Labels
bug Something isn't working namespace related to ns form parsing or printing v1 blocker Required for a v1.0.0 release

Comments

@oakmac
Copy link
Owner

oakmac commented Oct 17, 2024

Found while testing against the Metabase codebase:

   Batch processing can be disabled by setting the environment variable `MB_DISABLE_GROUPER_BATCH_PROCESSING=true`."
   (:require
-   ^{:clj-kondo/ignore [:discouraged-namespace]}
-   [grouper.core :as grouper]
-   [metabase.models.setting :refer [defsetting]]
-   [metabase.util.i18n :refer [deferred-tru]]
-   [potemkin :as p])
+    [grouper.core :as grouper]
+    [metabase.models.setting :refer [defsetting]]
+    [metabase.util.i18n :refer [deferred-tru]]
+    [potemkin :as p])
   (:import
-   (grouper.core Grouper)))
+    (grouper.core Grouper)))
@oakmac oakmac added namespace related to ns form parsing or printing bug Something isn't working v1 blocker Required for a v1.0.0 release labels Oct 17, 2024
@oakmac
Copy link
Owner Author

oakmac commented Oct 18, 2024

FYI to anyone who is effected by this bug right now:

You can use the discard form #_{:clj-kondo/ignore ...} above a :require line and it will work.

@oakmac
Copy link
Owner Author

oakmac commented Oct 19, 2024

This actually might be a bug / mistake in the metabase codebase? I see in the clj-kondo documentation that the discard form is intended for :clj-kondo/ignore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working namespace related to ns form parsing or printing v1 blocker Required for a v1.0.0 release
Projects
None yet
Development

No branches or pull requests

1 participant