Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change the way the app closes #82

Open
oakmac opened this issue Jan 29, 2015 · 0 comments
Open

change the way the app closes #82

oakmac opened this issue Jan 29, 2015 · 0 comments
Assignees

Comments

@oakmac
Copy link
Owner

oakmac commented Jan 29, 2015

This is an internal architecture enhancement.

Right now the app closes the "catch" event at the browser side, prevents default, and then sends an IPC signal to the window side in order to show the shutdown screen and kill any existing Leiningen processes that may still be running.

The problem is that if the window app reaches an invalid state (happens all the time in development), then you have to force-close the app in order to get it to shut down because the normal close event is always being trapped and waiting for the "shutdown-for-real" signal (which will never arrive since the app is in an invalid state).

In theory this should never be a problem, but in practice it seems to happen often. It's embarrassing that you have to force-close the app in this way when it breaks or encounters a bug we haven't anticipated.

We need to change the way this works so that it's easy to close the app when something breaks.

@oakmac oakmac self-assigned this Jan 29, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant