Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UIScrollView instead of UILabel in PhotoCaptionView #45

Closed
isayeter opened this issue Apr 12, 2015 · 1 comment
Closed

UIScrollView instead of UILabel in PhotoCaptionView #45

isayeter opened this issue Apr 12, 2015 · 1 comment
Assignees

Comments

@isayeter
Copy link

Is it possible to create a UIScrollView instead of UILabel in photo captions ?

When captions are too long it seems ugly in screen.

ios simulator screen shot apr 12 2015 10 14 50 pm

Instead of UILabel I think it will be good to create that label in scrollview like facebook does.

If the label has more than our pre defined lines (for example 5 lines) it will be converted to scrollview.

@cdzombak
Copy link
Contributor

cdzombak commented May 1, 2015

The photo captions we use are typically not that long, so we haven't (yet?) developed this internally. But we would welcome a pull request to this effect, and we'll leave this issue around as a reminder.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants