Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explore plugins modal should show install path as value of NYLAS_HOME #953

Open
danielbayley opened this issue Jan 11, 2016 · 5 comments
Open

Comments

@danielbayley
Copy link

…rather than [what I presume is hard-coded] ~/.nylas.

@mbilker
Copy link
Contributor

mbilker commented Jan 11, 2016

Thanks for the report @danielbayley. Are you installing an external plugin or developing a plugin? The Built-In plugins are hard-coded into the Nylas application. ~/.nylas is hardcoded, but that is being debated at #674.

@mbilker mbilker added the plugin label Jan 11, 2016
@danielbayley
Copy link
Author

Well actually at the moment I have NYLAS_HOME set to ~/Library/Application Support/Nylas N1 (where it should be on OS X…) but this seemed to cause a lot of bugs with plugins, especially N1-Markdown-Composer; so I presume ~/.nylas is hardcoded in a bunch of places (should always be a variable…)

As a temporary fix I just made a symbolic link at ~/.nylas to the Application Support folder which made a lot of problems go away…

@mbilker
Copy link
Contributor

mbilker commented Jan 11, 2016

That protocol handler handles all of the nylas:// links and any installed (non-bundled into app.asar) package has that hardcoded path. It should really use NylasEnv.getConfigDirPath() to get its path.

@mbilker mbilker added the bug label Jan 11, 2016
@bengotow
Copy link
Contributor

This would definitely be a good project to dig in to. ~/.nylas definitely should be a variable everywhere.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants