Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OSX - w2e 0.6.4b icon paths hardcoded in manifest - built app won't launch #188

Closed
Blatman opened this issue Mar 20, 2017 · 6 comments
Closed

Comments

@Blatman
Copy link

Blatman commented Mar 20, 2017

OSX 10.11.6 El Capitan
NWjs 0.20.3-osx

Using 0.6.4b the generated builds are not launching - the problem appears to be hard-coded icon paths in the package.json (should be stripped to relative paths) - tried 0.5.1b and all was OK.
Have attached screenshots and the test project to assist.

iconbuildbug.zip

@jyapayne
Copy link
Collaborator

Ah, something is going wrong with file copying. So here's the issue: if icons are outside the project directory (where the package.json exists) Web2Exe should copy them to that folder and replace the absolute path with the new path. The reason is that NW.js can't see anything outside that folder. For some reason, it looks like this behavior is not happening anymore.

As a workaround, you could copy those files inside your "Blank" folder and reference them in Web2Exe.

@Blatman
Copy link
Author

Blatman commented Mar 20, 2017

Right then - going bananas here but have found that putting the files in the Blank folder didn't work so well but if I just build it as normal and then edit the icon references in the generated app package the app will work fine (a hassle tho!). When I was trying the earlier builds of W2E to test I was being tripped up by the modified package.json file - came right when I restored the original package.json file. Also wondering why the webexe_settings are still in the package.json when there is now a separate web2exe.json file produced. Note: retried the 0.6.3b build and it was OK so the issue appears to be with the 0.6.4b build.

@jyapayne
Copy link
Collaborator

The webexe_settings should only be in the package.json if they were in there already before (when you were exporting with older versions it would have been added).
I'll try to have this fixed as soon as I can. It's probably creating a lot of grief for others as well.

@Blatman
Copy link
Author

Blatman commented Apr 11, 2017

Thanks Joey - can't check though - no W2E for Mac build in the 0.6.5 downloads.
I will wait in case the downloads are taking a while to update.
Cheers.

@jyapayne
Copy link
Collaborator

Hey man, sorry about that. I had issues building on my Mac last night. I'll put it up when I get home!

@jyapayne
Copy link
Collaborator

Should be up :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants