Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v0.19.2+] --single-process Is Not Working Properly (Running Two Separate Processes) #5624

Closed
TheRealDannyyy opened this issue Jan 10, 2017 · 9 comments

Comments

@TheRealDannyyy
Copy link

TheRealDannyyy commented Jan 10, 2017

General Information:

  • Using NW.js version 0.19.2 & newer
  • Windows 7 with latest drivers
  • Package.nw folder including package.json manifest
  • Task-Manager screenshot:
    Taskmanager Screenshot

Problem Description:
When I'm trying to run a packaged Construct 2 game (HTML5) while having "--single-process" set as a property in the chromium-args, NW.js runs a total of 2 processes instead of the intended single process.

Observed Result
NW.js single process starts to run with two processes using "--single-process" specified inside the package.json manifest.

Expected Result
NW.js should run fine with the single processing argument and always run with a single process.

@rogerwang
Copy link
Member

The additional process is used for crash dumping. And it's intended to be a separate process on windows: https://groups.google.com/a/chromium.org/d/msg/chromium-dev/gQ-IMJwedcs/ujos2lVTAAAJ

The other parts runs in the same process as expected.

Does this affect any aspect of you app?

@TheRealDannyyy
Copy link
Author

It affects some game recorders that are not able to detect games with multiple processes.

@rogerwang
Copy link
Member

Then we can have a workaround with an option to disable crash dumping.

@TheRealDannyyy
Copy link
Author

TheRealDannyyy commented Jan 12, 2017

Then we can have a workaround with an option to disable crash dumping.

That would be very much appreciated, thanks a lot!

@TheRealDannyyy TheRealDannyyy changed the title [v0.19.2+] --single-process Is Not Working Properly (Again) [v0.19.2+] --single-process Is Not Working Properly (Running Two Separate Processes) Jan 12, 2017
@TheRealDannyyy
Copy link
Author

TheRealDannyyy commented Feb 2, 2017

@GnorTech
Both 32bit and 64bit (nw.js 0.20.1) versions crash when I use "--disable-crash-handler=true" as a command line flag inside a shortcut. I specified "--single-process" inside the manifest and I followed the required steps as mentioned inside the docs.

All I can do is provide the crashlog by Windows (it's in German but you guys will surely figure it out).
Am doing something wrong or is it indeed not working properly?

@rogerwang
Copy link
Member

It's fixed again in git and will be available in the next nightly build of 0.20 branch.

@TheRealDannyyy
Copy link
Author

TheRealDannyyy commented Feb 6, 2017

It's fixed again in git and will be available in the next nightly build of 0.20 branch.

Thanks again.

@rogerwang
Copy link
Member

added tag to track the need for a test case for --disable-crash-handler=true

@TheRealDannyyy
Copy link
Author

TheRealDannyyy commented Jan 14, 2018

@rogerwang It works fine in NW.js v0.27.2 and I assume in previous versions as well.

This is off-topic but I'd really appreciate it if you could "merge" this feature with the --single-process arg or make it possible to disable the crash handler from the manifest.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants