-
-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FixCursorHold is no longer needed with Neovim v0.8.0. #192
Comments
Only one of the issues solved by the plugin was addressed so the recommendation still stands antoinemadec/FixCursorHold.nvim#13 |
Maybe it makes sense to copy the remaining functionality to neotest? I mean FixCursorHold is clearly not maintained. It is under MIT so with a thank you in README, copying the needed stuff over, and we could just remove the extra dependency. It is really not that big in terms of line of code. What do you think? |
For what reason though? Removing a dependency isn't a reason in itself. It hasn't had commits in a while but also hasn't had any issues because it is stable, even complete. |
I would say it's better for the UX, because it's less hussle for the user and also reduces the risk that something break in the future, especially if anything this plugin uses of it is already feature compete. But this is only my opinion. |
Closing as I don't wish to integrate the functionality into neotest at this time |
Quick question, if I use |
neotest/README.md
Lines 34 to 35 in fee5ce9
Per the linked issue, this was fixed upstream.
The text was updated successfully, but these errors were encountered: