Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

:Rocks sync fails on first install when rocks.toml has plugins that require rocks-git #607

Closed
craigmac opened this issue Dec 18, 2024 · 3 comments · Fixed by #608 or #610
Closed

Comments

@craigmac
Copy link
Contributor

Seems to be an out-or-order sort of bug. If I clone my nvim repo on new box, when I try doing a :Rocks sync I get messages about failures for the rocks that are dependent on rock-git being installed. Is there a way to prioritize rocks-git.nvim being installed and loaded first if it exists in the rocks.toml file?

Currently, the way to workaround this is just to close and open neovim and run :Rocks sync again, which will now work because rocks-git.nvim would have been installed the first time we ran :Rocks sync.

Alternatively, maybe there should be config = "rocks-git.toml" setting like was introduced for the rocks-treesitter.nvim plugin?

@craigmac
Copy link
Contributor Author

example rocks.toml:

[rocks]

[plugins]
"rocks.nvim" = "2.42.1"
"rocks-git.nvim" = "2.5.2"
"gitsigns.nvim" = "0.9.0"

[plugins.vim-fugitive]
git = "tpope/vim-fugitive"
rev = "v3.7"

@mrcjkb
Copy link
Member

mrcjkb commented Dec 18, 2024

Hey 👋

thanks for reporting. This appears to be a regression. I'll look into it 👀

@mrcjkb
Copy link
Member

mrcjkb commented Dec 18, 2024

Reopening, because the fix in #608 doesn't seem to fully fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants