Windows: pcall causing terminals to rapidly open/close

[MeguminSama]

I just installed rocks for the first time. Windows 11, using Windows Terminal (both PowerShell 7.4.5 & Command Prompt).

When I open nvim with rocks enabled, it causes new terminal windows to appear and disappear rapidly, making it impossible to work or even type :q.

After some debugging, it seems it is caused by setting opts.detach = true in the pcall in luarocks.lua. After setting this to false, the terminals stopped flashing.

Since it seems this was intentional (Prevent luarocks from exiting uncleanly), perhaps there's an alternative way to get a similar effect, without causing new terminal windows to open and close?

rocks.nvim/lua/rocks/luarocks.lua

Lines 89 to 91 in ce6e2bd

	log.info(luarocks_cmd)
	opts.detach = true -- Prevent luarocks from exiting uncleanly
	local ok, err = pcall(vim.system, luarocks_cmd, opts, on_exit_wrapped)

[mrcjkb]

Hey 👋

Thanks for the detailed report and debugging. 🙏

I think the only thing we can do here is to set it to false on Windows.