feat(log): trace luarocks_config path #450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrcjkb
requested changes
Jul 2, 2024
plugin/rocks.lua
Outdated
| @@ -18,6 +18,7 @@ end | |||
|
|
|||
| local log = require("rocks.log") | |||
| log.info(vim.uv.os_uname()) | |||
| log.info("Using luarocks config " .. (vim.g.rocks_nvim.luarocks_config or "unset")) | |||
There was a problem hiding this comment.
issue: we should get the luarocks config from the config module (see L27)
There was a problem hiding this comment.
ha yes ty. I noticed that after the initial implementation and forgot to correct it. The CI error looks unrelated
To help debug/diagnose if config is correctly set. It can be deceiving in case vim.g.rocks_nvim gets changed later. Which is why at first I thought of passing the luarocks config via the command line instead of the environment but luarocks still doesn't support it: luarocks/luarocks#1086 This looks like a good compromise.
mrcjkb
approved these changes
Jul 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To help debug/diagnose if config is correctly set. It can be deceiving in case vim.g.rocks_nvim gets changed later.
Which is why at first I thought of passing the luarocks config via the command line instead of the environment but luarocks still doesn't support it: luarocks/luarocks#1086
This looks like a good compromise.