Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] luarocks fails when neovim opened with file as an argument #18

Closed
boltlessengineer opened this issue Jul 14, 2024 · 1 comment · Fixed by nvim-neorocks/rocks.nvim#474

Comments

@boltlessengineer
Copy link
Contributor

I found error when opening neovim with file as an argument without tree-sitter parser.
Loading file with :e test.rs after opening neovim is fine.

Reproduce

  • run nvim test.rs
  • check :Rocks log

:Rocks log output:

[START][2024-07-14 09:30:01] rocks.nvim logging initiated
INFO | 2024-07-14 09:30:01 | .../luarocks/rocks-5.1/rocks.nvim/2.35.1-1/plugin/rocks.lua:20 | {
  machine = "aarch64",
  release = "5.15.0-1051-oracle",
  sysname = "Linux",
  version = "#57-Ubuntu SMP Wed Jan 24 18:31:24 UTC 2024"
}
INFO | 2024-07-14 09:30:01 | .../share/nvim_rocks/rocks/rocks_rtp/lua/rocks/luarocks.lua:88 | { "/home/ubuntu/.local/share/nvim_rocks/rocks/lib/luarocks/rocks-5.1/luarocks/3.11.1-1/bin/luarocks", "--force-lock", "--lua-version=5.1", "--tree=/home/ubuntu/.local/share/nvim_rocks/rocks", "--server='https://nvim-neorocks.github.io/rocks-binaries-dev/'", "--server='https://luarocks.org/manifests/neorocks/'", "--server='https://nvim-neorocks.github.io/rocks-binaries/'", "search", "--porcelain", "--all", "--dev" }
INFO | 2024-07-14 09:30:01 | .../share/nvim_rocks/rocks/rocks_rtp/lua/rocks/luarocks.lua:88 | { "/home/ubuntu/.local/share/nvim_rocks/rocks/lib/luarocks/rocks-5.1/luarocks/3.11.1-1/bin/luarocks", "--force-lock", "--lua-version=5.1", "--tree=/home/ubuntu/.local/share/nvim_rocks/rocks", "list", "--porcelain" }
INFO | 2024-07-14 09:30:01 | .../share/nvim_rocks/rocks/rocks_rtp/lua/rocks/luarocks.lua:88 | { "/home/ubuntu/.local/share/nvim_rocks/rocks/lib/luarocks/rocks-5.1/luarocks/3.11.1-1/bin/luarocks", "--force-lock", "--lua-version=5.1", "--tree=/home/ubuntu/.local/share/nvim_rocks/rocks", "--server='https://nvim-neorocks.github.io/rocks-binaries-dev/'", "--server='https://luarocks.org/manifests/neorocks/'", "--server='https://nvim-neorocks.github.io/rocks-binaries/'", "search", "--porcelain", "--all", "--dev" }
INFO | 2024-07-14 09:30:01 | .../share/nvim_rocks/rocks/rocks_rtp/lua/rocks/luarocks.lua:88 | { "/home/ubuntu/.local/share/nvim_rocks/rocks/lib/luarocks/rocks-5.1/luarocks/3.11.1-1/bin/luarocks", "--force-lock", "--lua-version=5.1", "--tree=/home/ubuntu/.local/share/nvim_rocks/rocks", "--server='https://nvim-neorocks.github.io/rocks-binaries-dev/'", "--server='https://luarocks.org/manifests/neorocks/'", "--server='https://nvim-neorocks.github.io/rocks-binaries/'", "search", "--porcelain", "--all", "--dev" }
INFO | 2024-07-14 09:30:01 | .../share/nvim_rocks/rocks/rocks_rtp/lua/rocks/luarocks.lua:88 | { "/home/ubuntu/.local/share/nvim_rocks/rocks/lib/luarocks/rocks-5.1/luarocks/3.11.1-1/bin/luarocks", "--force-lock", "--lua-version=5.1", "--tree=/home/ubuntu/.local/share/nvim_rocks/rocks", "list", "--porcelain" }
INFO | 2024-07-14 09:30:01 | .../share/nvim_rocks/rocks/rocks_rtp/lua/rocks/luarocks.lua:88 | { "/home/ubuntu/.local/share/nvim_rocks/rocks/lib/luarocks/rocks-5.1/luarocks/3.11.1-1/bin/luarocks", "--force-lock", "--lua-version=5.1", "--tree=/home/ubuntu/.local/share/nvim_rocks/rocks", "show", "--porcelain", "toml-edit" }
INFO | 2024-07-14 09:30:01 | .../share/nvim_rocks/rocks/rocks_rtp/lua/rocks/luarocks.lua:88 | { "/home/ubuntu/.local/share/nvim_rocks/rocks/lib/luarocks/rocks-5.1/luarocks/3.11.1-1/bin/luarocks", "--force-lock", "--lua-version=5.1", "--tree=/home/ubuntu/.local/share/nvim_rocks/rocks", "show", "--porcelain", "fidget.nvim" }
INFO | 2024-07-14 09:30:01 | .../share/nvim_rocks/rocks/rocks_rtp/lua/rocks/luarocks.lua:88 | { "/home/ubuntu/.local/share/nvim_rocks/rocks/lib/luarocks/rocks-5.1/luarocks/3.11.1-1/bin/luarocks", "--force-lock", "--lua-version=5.1", "--tree=/home/ubuntu/.local/share/nvim_rocks/rocks", "show", "--porcelain", "rtp.nvim" }
INFO | 2024-07-14 09:30:01 | .../share/nvim_rocks/rocks/rocks_rtp/lua/rocks/luarocks.lua:88 | { "/home/ubuntu/.local/share/nvim_rocks/rocks/lib/luarocks/rocks-5.1/luarocks/3.11.1-1/bin/luarocks", "--force-lock", "--lua-version=5.1", "--tree=/home/ubuntu/.local/share/nvim_rocks/rocks", "show", "--porcelain", "fzy" }
INFO | 2024-07-14 09:30:01 | .../share/nvim_rocks/rocks/rocks_rtp/lua/rocks/luarocks.lua:88 | { "/home/ubuntu/.local/share/nvim_rocks/rocks/lib/luarocks/rocks-5.1/luarocks/3.11.1-1/bin/luarocks", "--force-lock", "--lua-version=5.1", "--tree=/home/ubuntu/.local/share/nvim_rocks/rocks", "show", "--porcelain", "luarocks-build-rust-mlua" }
INFO | 2024-07-14 09:30:01 | .../share/nvim_rocks/rocks/rocks_rtp/lua/rocks/luarocks.lua:88 | { "/home/ubuntu/.local/share/nvim_rocks/rocks/lib/luarocks/rocks-5.1/luarocks/3.11.1-1/bin/luarocks", "--force-lock", "--lua-version=5.1", "--tree=/home/ubuntu/.local/share/nvim_rocks/rocks", "show", "--porcelain", "rocks.nvim" }
INFO | 2024-07-14 09:30:01 | .../share/nvim_rocks/rocks/rocks_rtp/lua/rocks/luarocks.lua:88 | { "/home/ubuntu/.local/share/nvim_rocks/rocks/lib/luarocks/rocks-5.1/luarocks/3.11.1-1/bin/luarocks", "--force-lock", "--lua-version=5.1", "--tree=/home/ubuntu/.local/share/nvim_rocks/rocks", "show", "--porcelain", "nvim-nio" }
INFO | 2024-07-14 09:30:01 | .../share/nvim_rocks/rocks/rocks_rtp/lua/rocks/luarocks.lua:88 | { "/home/ubuntu/.local/share/nvim_rocks/rocks/lib/luarocks/rocks-5.1/luarocks/3.11.1-1/bin/luarocks", "--force-lock", "--lua-version=5.1", "--tree=/home/ubuntu/.local/share/nvim_rocks/rocks", "show", "--porcelain", "luarocks" }
INFO | 2024-07-14 09:30:01 | .../share/nvim_rocks/rocks/rocks_rtp/lua/rocks/luarocks.lua:88 | { "/home/ubuntu/.local/share/nvim_rocks/rocks/lib/luarocks/rocks-5.1/luarocks/3.11.1-1/bin/luarocks", "--force-lock", "--lua-version=5.1", "--tree=/home/ubuntu/.local/share/nvim_rocks/rocks", "show", "--porcelain", "rocks-treesitter.nvim" }
ERROR | 2024-07-14 09:30:02 | .../share/nvim_rocks/rocks/rocks_rtp/lua/rocks/luarocks.lua:64 | luarocks CLI FAILED
ERROR | 2024-07-14 09:30:02 | .../share/nvim_rocks/rocks/rocks_rtp/lua/rocks/luarocks.lua:65 | ln: failed to create hard link '/home/ubuntu/.cache/luarocks/https___nvim-neorocks.github.io_rocks-binaries_dev/lockfile.lfs': File exists
ln: failed to create hard link '/tmp/luarocks_local_cache-7419740/https___nvim-neorocks.github.io_rocks-binaries_dev/lockfile.lfs': File exists

Error: LuaRocks 3.11.1 bug (please report at https://github.com/luarocks/luarocks/issues).
Arch.: linux-aarch64
...rocks/rocks/share/lua/5.1/luarocks/fs/unix/tools.lua:349: attempt to index local 'lock' (a nil value)
stack traceback:
	...rocks/rocks/share/lua/5.1/luarocks/fs/unix/tools.lua:349: in function <...rocks/rocks/share/lua/5.1/luarocks/fs/unix/tools.lua:348>
	(tail call): ?
	...re/nvim_rocks/rocks/share/lua/5.1/luarocks/fetch.lua:66: in function 'fetch_caching'
	...re/nvim_rocks/rocks/share/lua/5.1/luarocks/manif.lua:108: in function 'load_manifest'
	...e/nvim_rocks/rocks/share/lua/5.1/luarocks/search.lua:111: in function <...e/nvim_rocks/rocks/share/lua/5.1/luarocks/search.lua:101>
	(tail call): ?
	...e/nvim_rocks/rocks/share/lua/5.1/luarocks/search.lua:155: in function 'search_repos'
	...im_rocks/rocks/share/lua/5.1/luarocks/cmd/search.lua:68: in function <...im_rocks/rocks/share/lua/5.1/luarocks/cmd/search.lua:56>
	(tail call): ?
	[C]: in function 'xpcall'
	...hare/nvim_rocks/rocks/share/lua/5.1/luarocks/cmd.lua:765: in function 'run_command'
	...ib/luarocks/rocks-5.1/luarocks/3.11.1-1/bin/luarocks:35: in main chunk
	[C]: ?

rocks.toml

[rocks]

[plugins]
"rocks.nvim" = "2.35.1"
"rocks-treesitter.nvim" = "scm"

[treesitter]
auto_highlight = "all"

By adjusting some internal code, I found the error was happening while running first search --all command:

luarocks --force-lock --lua-version=5.1 --tree=/home/ubuntu/.local/share/nvim_rocks/rocks --server='https://nvim-neorocks.github.io/rocks-binaries-dev/' --server='https://luarocks.org/manifests/neorocks/' --server='https://nvim-neorocks.github.io/rocks-binaries/' search --porcelain --all --dev

which was executed from:

local function find_parser_rock(lang, callback)
local rock_name = "tree-sitter-" .. lang
local rocks = api.try_get_cached_rocks()
if rocks and rocks[rock_name] then
return callback(rocks[rock_name])
end
-- Cache may not have been populated. Query luarocks.
api.query_luarocks_rocks(function(luarocks_rocks)
callback(luarocks_rocks[rock_name] or {})
end)
end

But I don’t get any error when I manually run that command with luarocks 3.11.1-dev version.
Even :=require("rocks.api").query_luarocks_rocks(function(res) vim.print(res["tree-sitter-rust"]) end) was fine.

I guess some initialization hasn’t executed before the FileType autocommand but couldn’t find it.

@boltlessengineer boltlessengineer changed the title [Bug] luarocks fails when neovim opened file with arguments [Bug] luarocks fails when neovim opened with file as an argument Jul 14, 2024
@mrcjkb
Copy link
Member

mrcjkb commented Jul 14, 2024

Hey 👋

thanks for the report.
This is an issue with the luarocks locking mechanism.
As a workaround, I guess we have to synchronise all invocations of the luarocks CLI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants